From bb04892baf53466c55862ca4ccf86e0f43b9eedf Mon Sep 17 00:00:00 2001 From: Jason Dellaluce Date: Thu, 18 May 2023 12:45:00 +0000 Subject: [PATCH] fix(userspace/falco): avoid double plugin initializations Signed-off-by: Jason Dellaluce --- userspace/falco/app/actions/init_inspectors.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/userspace/falco/app/actions/init_inspectors.cpp b/userspace/falco/app/actions/init_inspectors.cpp index 6fb4e403..d1f763aa 100644 --- a/userspace/falco/app/actions/init_inspectors.cpp +++ b/userspace/falco/app/actions/init_inspectors.cpp @@ -159,9 +159,14 @@ falco::app::run_result falco::app::actions::init_inspectors(falco::app::state& s // (in capture mode, this is true for every plugin) if (plugin) { - if (!plugin->init(config->m_init_config, err)) + // avoid initializing the same plugin twice in the same + // inspector if we're in capture mode + if (!s.is_capture_mode() || used_plugins.find(p->name()) == used_plugins.end()) { - return run_result::fatal(err); + if (!plugin->init(config->m_init_config, err)) + { + return run_result::fatal(err); + } } if (is_input) {