github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-09-13 05:22:34 +00:00
Code Issues Projects Releases Wiki Activity

update: address some review comments

Browse Source 
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
This commit is contained in:
Andrea Terzolo
2022-09-20 15:52:12 +00:00
committed by poiana
parent 90e4634a79
commit c9fa585801
5 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
userspace/falco/app_actions/compute_syscall_buffer_size.cpp
View File

@@ -33,7 +33,7 @@ application::run_result application::configure_syscall_buffer_size()
return run_result::ok();
}
uint16_t index = m_state->config->m_syscall_buffer_index;
uint16_t index = m_state->config->m_syscall_buf_size_preset;
if(index < MIN_INDEX || index > MAX_INDEX)
{
return run_result::fatal("The index must be between '" + std::to_string(MIN_INDEX) + "' and '" + std::to_string(MAX_INDEX) + "'\n");

2
userspace/falco/app_cmdline_options.cpp
View File

@@ -204,7 +204,7 @@ void cmdline_options::define()
("V,validate", "Read the contents of the specified rules(s) file and exit. Can be specified multiple times to validate multiple files.", cxxopts::value(validate_rules_filenames), "<rules_file>")
("v", "Verbose output.", cxxopts::value(verbose)->default_value("false"))
("version", "Print version number.", cxxopts::value(print_version_info)->default_value("false"))
("page-size", "Print the system page size used to choose the syscall buffer size.", cxxopts::value(print_page_size)->default_value("false"));
("page-size", "Print the system page size (may help you to choose the right syscall buffer size).", cxxopts::value(print_page_size)->default_value("false"));
m_cmdline_opts.set_width(140);

2
userspace/falco/configuration.cpp
View File

@@ -288,7 +288,7 @@ void falco_configuration::init(string conf_filename, const vector<string> &cmdli
/* We put this value in the configuration file because in this way we can change the dimension at every reload.
* The default value is `4` -> 8 MB.
*/
m_syscall_buffer_index = m_config->get_scalar<uint64_t>("syscall_buffer_index", 4);
m_syscall_buf_size_preset = m_config->get_scalar<uint64_t>("syscall_buf_size_preset", 4);
std::set<std::string> load_plugins;

2
userspace/falco/configuration.h
View File

@@ -270,7 +270,7 @@ public:
uint32_t m_metadata_download_watch_freq_sec;
// Index corresponding to the syscall buffer dimension.
uint64_t m_syscall_buffer_index;
uint64_t m_syscall_buf_size_preset;
std::vector<plugin_config> m_plugins;