github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-08-07 01:03:53 +00:00
Code Issues Projects Releases Wiki Activity

fix(userspace/engine): avoid storing escaped strings in engine defs

Browse Source 
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
This commit is contained in:
Jason Dellaluce 2024-01-22 10:38:48 +00:00 committed by poiana
parent 10eaf31881
commit ccf62a3745
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
userspace/engine/rule_loader_compiler.cpp
View File

@ -181,6 +181,7 @@ static bool resolve_list(std::string& cnd, const falco_list& list)
{ {
static std::string blanks = " \t\n\r"; static std::string blanks = " \t\n\r";
static std::string delims = blanks + "(),="; static std::string delims = blanks + "(),=";
std::string tmp;
std::string new_cnd; std::string new_cnd;
size_t start, end; size_t start, end;
bool used = false; bool used = false;
@ -212,7 +213,9 @@ static bool resolve_list(std::string& cnd, const falco_list& list)
{ {
sub += ", "; sub += ", ";
} }
sub += v; tmp = v;
quote_item(tmp);
sub += tmp;
} }
// if substituted list is empty, we need to // if substituted list is empty, we need to
// remove a comma from the left or the right // remove a comma from the left or the right
@ -339,7 +342,6 @@ void rule_loader::compiler::compile_list_infos(
const collector& col, const collector& col,
indexed_vector<falco_list>& out) const indexed_vector<falco_list>& out) const
{ {
std::string tmp;
std::list<std::string> used; std::list<std::string> used;
falco_list v; falco_list v;
for (const auto &list : col.lists()) for (const auto &list : col.lists())
@ -352,17 +354,14 @@ void rule_loader::compiler::compile_list_infos(
if (ref && ref->index < list.visibility) if (ref && ref->index < list.visibility)
{ {
used.push_back(ref->name); used.push_back(ref->name);
for (auto val : ref->items) for (const auto &val : ref->items)
{ {
quote_item(val);
v.items.push_back(val); v.items.push_back(val);
} }
} }
else else
{ {
tmp = item; v.items.push_back(item);
quote_item(tmp);
v.items.push_back(tmp);
} }
} }
v.used = false; v.used = false;