github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-07-15 23:36:19 +00:00
Code Issues Projects Releases Wiki Activity

fix(userspace/falco): only enable prometheus metrics once all inspectors have been opened.

Browse Source 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
This commit is contained in:
Federico Di Pierro 2025-05-30 09:04:44 +02:00 committed by poiana
parent b94cda0b12
commit d6fc8c63e5
3 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
userspace/falco/app/actions/process_events.cpp
View File

@ -491,6 +491,9 @@ falco::app::run_result falco::app::actions::process_events(falco::app::state& s)
} }
if(s.enabled_sources.size() == 1) { if(s.enabled_sources.size() == 1) {
// Since the inspector is now opened, we can enable prometheus metrics
s.webserver.enable_prometheus_metrics(s);
// optimization: with only one source we don't spawn additional threads // optimization: with only one source we don't spawn additional threads
process_inspector_events(s, process_inspector_events(s,
src_info->inspector, src_info->inspector,
@ -520,6 +523,10 @@ falco::app::run_result falco::app::actions::process_events(falco::app::state& s)
break; break;
} }
} }
if(s.enabled_sources.size() > 1) {
// Since all inspectors are now opened, we can enable prometheus metrics
s.webserver.enable_prometheus_metrics(s);
}
// wait for event processing to terminate for all sources // wait for event processing to terminate for all sources
// if a thread terminates with an error, we trigger the app termination // if a thread terminates with an error, we trigger the app termination

16
userspace/falco/webserver.cpp
View File

@ -58,12 +58,6 @@ void falco_webserver::start(const falco::app::state &state,
res.set_content(versions_json_str, "application/json"); res.set_content(versions_json_str, "application/json");
}); });
if(state.config->m_metrics_enabled && webserver_config.m_prometheus_metrics_enabled) {
m_server->Get("/metrics", [&state](const httplib::Request &, httplib::Response &res) {
res.set_content(falco_metrics::to_text_prometheus(state),
falco_metrics::content_type_prometheus);
});
}
// run server in a separate thread // run server in a separate thread
if(!m_server->is_valid()) { if(!m_server->is_valid()) {
m_server = nullptr; m_server = nullptr;
@ -106,3 +100,13 @@ void falco_webserver::stop() {
m_running = false; m_running = false;
} }
} }
void falco_webserver::enable_prometheus_metrics(const falco::app::state &state) {
if(state.config->m_metrics_enabled &&
state.config->m_webserver_config.m_prometheus_metrics_enabled) {
m_server->Get("/metrics", [&state](const httplib::Request &, httplib::Response &res) {
res.set_content(falco_metrics::to_text_prometheus(state),
falco_metrics::content_type_prometheus);
});
}
}

1
userspace/falco/webserver.h
View File

@ -40,6 +40,7 @@ public:
virtual void start(const falco::app::state& state, virtual void start(const falco::app::state& state,
const falco_configuration::webserver_config& webserver_config); const falco_configuration::webserver_config& webserver_config);
virtual void stop(); virtual void stop();
virtual void enable_prometheus_metrics(const falco::app::state& state);
private: private:
bool m_running = false; bool m_running = false;