github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-06-28 07:37:32 +00:00
Code Issues Projects Releases Wiki Activity

fix: print full rule load errors without verbose/-v

Browse Source 
The latest released falco always prints full details on errors when
used with -r (read rules)/-V (validate rules). However #2098 changed
this to only print full details when verbose is true.

Fix the regression by always printing errors when loading
rules. Warnings will be printed only with -v.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
This commit is contained in:
Mark Stemm 2022-08-04 14:47:05 -05:00 committed by poiana
parent 2a640daf13
commit fefd23f2f1
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
userspace/falco/app_actions/load_rules_files.cpp
View File

@ -100,9 +100,7 @@ application::run_result application::load_rules_files()
res = m_state->engine->load_rules_file(filename); res = m_state->engine->load_rules_file(filename);
// Print the full output if verbose is true if((!res->successful() || (m_options.verbose && res->has_warnings())))
if(m_options.verbose &&
(!res->successful() || res->has_warnings()))
{ {
printf("%s\n", printf("%s\n",
(m_state->config->m_json_output ? (m_state->config->m_json_output ?

4
userspace/falco/app_actions/validate_rules_files.cpp
View File

@ -56,9 +56,7 @@ application::run_result application::validate_rules_files()
} }
else else
{ {
// Print the full output when verbose is true if(!res->successful() || (m_options.verbose && res->has_warnings()))
if(m_options.verbose &&
(!res->successful() || res->has_warnings()))
{ {
printf("%s\n", res->as_string(true).c_str()); printf("%s\n", res->as_string(true).c_str());
} }