From 018a88590c6510c935bce3c46e91f810b6891ddc Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 11 Feb 2026 02:58:56 +0100 Subject: [PATCH] Remove striped tables in UI (#36509) We've been cutting down on the "striped" tables (where rows are using alternate row background colors). This completely removes them as I think such a design looks outdated. The removal of selectors starting with `.ui[class*="very basic"].table:not(.striped)` is needed because of a specificity issue in the CSS where table cells would otherwise render with incorrect padding. Example of one affected table: image --- templates/admin/auth/list.tmpl | 2 +- templates/admin/cron.tmpl | 2 +- templates/admin/emails/list.tmpl | 2 +- templates/admin/notice.tmpl | 2 +- templates/admin/org/list.tmpl | 2 +- templates/admin/packages/list.tmpl | 2 +- templates/admin/queue.tmpl | 2 +- templates/admin/queue_manage.tmpl | 2 +- templates/admin/repo/list.tmpl | 2 +- templates/admin/stats.tmpl | 2 +- templates/admin/user/list.tmpl | 2 +- .../package/shared/cleanup_rules/preview.tmpl | 2 +- templates/repo/branch/list.tmpl | 4 +-- templates/repo/commits_list.tmpl | 2 +- templates/shared/actions/runner_edit.tmpl | 2 +- templates/shared/actions/runner_list.tmpl | 2 +- web_src/css/modules/table.css | 32 ------------------- web_src/css/repo.css | 4 --- 18 files changed, 17 insertions(+), 53 deletions(-) diff --git a/templates/admin/auth/list.tmpl b/templates/admin/auth/list.tmpl index a1e72b742f2..7296e955584 100644 --- a/templates/admin/auth/list.tmpl +++ b/templates/admin/auth/list.tmpl @@ -7,7 +7,7 @@
- +
diff --git a/templates/admin/cron.tmpl b/templates/admin/cron.tmpl index 4d01ce51eb6..8e44614d97a 100644 --- a/templates/admin/cron.tmpl +++ b/templates/admin/cron.tmpl @@ -5,7 +5,7 @@
-
ID
+
diff --git a/templates/admin/emails/list.tmpl b/templates/admin/emails/list.tmpl index 50e453916df..d597a2753f5 100644 --- a/templates/admin/emails/list.tmpl +++ b/templates/admin/emails/list.tmpl @@ -24,7 +24,7 @@
-
+
diff --git a/templates/admin/notice.tmpl b/templates/admin/notice.tmpl index 0499b0adbb8..7e08946f23b 100644 --- a/templates/admin/notice.tmpl +++ b/templates/admin/notice.tmpl @@ -3,7 +3,7 @@

{{ctx.Locale.Tr "admin.notices.system_notice_list"}} ({{ctx.Locale.Tr "admin.total" .Total}})

- +
diff --git a/templates/admin/org/list.tmpl b/templates/admin/org/list.tmpl index 137c42b45d6..c2c0280e4cd 100644 --- a/templates/admin/org/list.tmpl +++ b/templates/admin/org/list.tmpl @@ -29,7 +29,7 @@
-
+
diff --git a/templates/admin/packages/list.tmpl b/templates/admin/packages/list.tmpl index 4d458f48fba..553130ae093 100644 --- a/templates/admin/packages/list.tmpl +++ b/templates/admin/packages/list.tmpl @@ -26,7 +26,7 @@
-
ID{{SortArrow "oldest" "newest" $.SortType false}}
+
diff --git a/templates/admin/queue.tmpl b/templates/admin/queue.tmpl index 1be35cf7659..e6abd1e7945 100644 --- a/templates/admin/queue.tmpl +++ b/templates/admin/queue.tmpl @@ -4,7 +4,7 @@ {{ctx.Locale.Tr "admin.monitor.queues"}}
-
ID
+
diff --git a/templates/admin/queue_manage.tmpl b/templates/admin/queue_manage.tmpl index a793fe1350a..73da9164cc1 100644 --- a/templates/admin/queue_manage.tmpl +++ b/templates/admin/queue_manage.tmpl @@ -4,7 +4,7 @@ {{ctx.Locale.Tr "admin.monitor.queue" .Queue.GetName}}
-
{{ctx.Locale.Tr "admin.monitor.queue.name"}}
+
diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl index f21e5bfef22..0af9df2551d 100644 --- a/templates/admin/repo/list.tmpl +++ b/templates/admin/repo/list.tmpl @@ -10,7 +10,7 @@ {{template "shared/repo/search" .}}
-
{{ctx.Locale.Tr "admin.monitor.queue.name"}}
+
diff --git a/templates/admin/stats.tmpl b/templates/admin/stats.tmpl index 04fa862a85c..bb6a86ac301 100644 --- a/templates/admin/stats.tmpl +++ b/templates/admin/stats.tmpl @@ -4,7 +4,7 @@ {{ctx.Locale.Tr "admin.dashboard.statistic"}}
-
ID{{SortArrow "oldest" "newest" $.SortType false}}
+
{{range $statsKey := .StatsKeys}} diff --git a/templates/admin/user/list.tmpl b/templates/admin/user/list.tmpl index 49f62dda748..168603354db 100644 --- a/templates/admin/user/list.tmpl +++ b/templates/admin/user/list.tmpl @@ -56,7 +56,7 @@
-
{{$statsKey}}
+
diff --git a/templates/package/shared/cleanup_rules/preview.tmpl b/templates/package/shared/cleanup_rules/preview.tmpl index bb2354c9441..0991a07fbc2 100644 --- a/templates/package/shared/cleanup_rules/preview.tmpl +++ b/templates/package/shared/cleanup_rules/preview.tmpl @@ -3,7 +3,7 @@

{{ctx.Locale.Tr "packages.owner.settings.cleanuprules.preview.overview" (len .VersionsToRemove)}}

-
ID{{SortArrow "oldest" "newest" .SortType false}}
+
diff --git a/templates/repo/branch/list.tmpl b/templates/repo/branch/list.tmpl index 9f6f24bbf42..5b56b3ed42d 100644 --- a/templates/repo/branch/list.tmpl +++ b/templates/repo/branch/list.tmpl @@ -15,7 +15,7 @@
-
{{ctx.Locale.Tr "admin.packages.type"}}
+
@@ -83,7 +83,7 @@
- +
{{range .Branches}} diff --git a/templates/repo/commits_list.tmpl b/templates/repo/commits_list.tmpl index 959f2a93985..1a236582a26 100644 --- a/templates/repo/commits_list.tmpl +++ b/templates/repo/commits_list.tmpl @@ -1,5 +1,5 @@
-
+
diff --git a/templates/shared/actions/runner_edit.tmpl b/templates/shared/actions/runner_edit.tmpl index 8c434971ad6..8652d161bcd 100644 --- a/templates/shared/actions/runner_edit.tmpl +++ b/templates/shared/actions/runner_edit.tmpl @@ -49,7 +49,7 @@ {{ctx.Locale.Tr "actions.runners.task_list"}}
-
{{ctx.Locale.Tr "repo.commits.author"}}
+
diff --git a/templates/shared/actions/runner_list.tmpl b/templates/shared/actions/runner_list.tmpl index 4545d4f16d1..9c541c95ee3 100644 --- a/templates/shared/actions/runner_list.tmpl +++ b/templates/shared/actions/runner_list.tmpl @@ -41,7 +41,7 @@
-
{{ctx.Locale.Tr "actions.runners.task_list.run"}}
+
diff --git a/web_src/css/modules/table.css b/web_src/css/modules/table.css index 6298471d474..c7d6cb7a485 100644 --- a/web_src/css/modules/table.css +++ b/web_src/css/modules/table.css @@ -196,11 +196,6 @@ margin-bottom: 0; } -.ui.striped.table > tr:nth-child(2n), -.ui.striped.table > tbody > tr:nth-child(2n) { - background: var(--color-light); -} - .ui.table[class*="single line"], .ui.table [class*="single line"] { white-space: nowrap; @@ -291,37 +286,10 @@ .ui.basic.table > tr > td { background: transparent; } -.ui.basic.striped.table > tbody > tr:nth-child(2n) { - background: var(--color-light); -} -.ui.basic.striped.selectable.table > tbody > tr:nth-child(2n):hover { - background: var(--color-hover); -} .ui[class*="very basic"].table { border: none; } -.ui[class*="very basic"].table:not(.striped) > tr > th:first-child, -.ui[class*="very basic"].table:not(.striped) > thead > tr > th:first-child, -.ui[class*="very basic"].table:not(.striped) > tbody > tr > th:first-child, -.ui[class*="very basic"].table:not(.striped) > tfoot > tr > th:first-child, -.ui[class*="very basic"].table:not(.striped) > tr > td:first-child, -.ui[class*="very basic"].table:not(.striped) > tbody > tr > td:first-child, -.ui[class*="very basic"].table:not(.striped) > tfoot > tr > td:first-child { - padding-left: 0; -} -.ui[class*="very basic"].table:not(.striped) > tr > th:last-child, -.ui[class*="very basic"].table:not(.striped) > thead > tr > th:last-child, -.ui[class*="very basic"].table:not(.striped) > tbody > tr > th:last-child, -.ui[class*="very basic"].table:not(.striped) > tfoot > tr > th:last-child, -.ui[class*="very basic"].table:not(.striped) > tr > td:last-child, -.ui[class*="very basic"].table:not(.striped) > tbody > tr > td:last-child, -.ui[class*="very basic"].table:not(.striped) > tfoot > tr > td:last-child { - padding-right: 0; -} -.ui[class*="very basic"].table:not(.striped) > thead > tr:first-child > th { - padding-top: 0; -} .ui.celled.table > tr > th, .ui.celled.table > thead > tr > th, diff --git a/web_src/css/repo.css b/web_src/css/repo.css index 16fbfaec4a1..83df3e5c292 100644 --- a/web_src/css/repo.css +++ b/web_src/css/repo.css @@ -774,10 +774,6 @@ td .commit-summary { width: 200px; } -.repository #commits-table.ui.basic.striped.table tbody tr:nth-child(2n) { - background-color: var(--color-light) !important; -} - .repository .data-table { width: 100%; }