github/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-08-21 04:33:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve the comment

Browse Source
This commit is contained in:
Lunny Xiao 2025-07-19 11:13:25 -07:00
parent c89d939b54
commit 0295c7bf01
No known key found for this signature in database
GPG Key ID: C3B7C91B632F738A
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
services/org/org.go
View File

@ -48,11 +48,14 @@ func deleteOrganization(ctx context.Context, org *org_model.Organization) error
// DeleteOrganization completely and permanently deletes everything of organization. // DeleteOrganization completely and permanently deletes everything of organization.
func DeleteOrganization(ctx context.Context, org *org_model.Organization, purge bool) error { func DeleteOrganization(ctx context.Context, org *org_model.Organization, purge bool) error {
// The repositories deletion of the organization cannot be under a transaction, // Deleting repositories under the organization cannot be wrapped in a transaction at the moment,
// because it cannot be rolled back because the content in disk will be deleted // because the associated disk content is permanently deleted by the DeleteOwnerRepositoriesDirectly function,
// in the DeleteOwnerRepositoriesDirectly function. // which cannot be rolled back.
// Even not all repositories deleted successfully, we still delete the organization again. //
// TODO: We should mark all the repositories as deleted and delete them in a background job. // Even if some repositories fail to delete, the organization will still be deleted.
//
// TODO: Consider marking repositories as "deleted" first,
// and handling the actual deletion in a background job for better reliability and rollback support.
if purge { if purge {
err := repo_service.DeleteOwnerRepositoriesDirectly(ctx, org.AsUser()) err := repo_service.DeleteOwnerRepositoriesDirectly(ctx, org.AsUser())
if err != nil { if err != nil {