mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 04:42:40 +00:00 
			
		
		
		
	Mock external service in hcaptcha TestCaptcha (#35604)
The test calls out to a web service which may be down or unreachable as seen in the linked issue. It's better for tests to not have such external dependencies to make them absolutely stable. Fixes: https://github.com/go-gitea/gitea/issues/35571
This commit is contained in:
		@@ -4,7 +4,10 @@
 | 
			
		||||
package hcaptcha
 | 
			
		||||
 | 
			
		||||
import (
 | 
			
		||||
	"errors"
 | 
			
		||||
	"io"
 | 
			
		||||
	"net/http"
 | 
			
		||||
	"net/url"
 | 
			
		||||
	"os"
 | 
			
		||||
	"strings"
 | 
			
		||||
	"testing"
 | 
			
		||||
@@ -21,6 +24,33 @@ func TestMain(m *testing.M) {
 | 
			
		||||
	os.Exit(m.Run())
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
type mockTransport struct{}
 | 
			
		||||
 | 
			
		||||
func (mockTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 | 
			
		||||
	if req.URL.String() != verifyURL {
 | 
			
		||||
		return nil, errors.New("unsupported url")
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	body, err := io.ReadAll(req.Body)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return nil, err
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	bodyValues, err := url.ParseQuery(string(body))
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return nil, err
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	var responseText string
 | 
			
		||||
	if bodyValues.Get("response") == dummyToken {
 | 
			
		||||
		responseText = `{"success":true,"credit":false,"hostname":"dummy-key-pass","challenge_ts":"2025-10-08T16:02:56.136Z"}`
 | 
			
		||||
	} else {
 | 
			
		||||
		responseText = `{"success":false,"error-codes":["invalid-input-response"]}`
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	return &http.Response{Request: req, Body: io.NopCloser(strings.NewReader(responseText))}, nil
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestCaptcha(t *testing.T) {
 | 
			
		||||
	tt := []struct {
 | 
			
		||||
		Name   string
 | 
			
		||||
@@ -55,6 +85,7 @@ func TestCaptcha(t *testing.T) {
 | 
			
		||||
		t.Run(tc.Name, func(t *testing.T) {
 | 
			
		||||
			client, err := New(tc.Secret, WithHTTP(&http.Client{
 | 
			
		||||
				Timeout:   time.Second * 5,
 | 
			
		||||
				Transport: mockTransport{},
 | 
			
		||||
			}))
 | 
			
		||||
			if err != nil {
 | 
			
		||||
				// The only error that can be returned from creating a client
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user