From 420b8520d26cf42adf6164b6c1a78d7ee55d2ead Mon Sep 17 00:00:00 2001 From: Tyrone Yeh Date: Thu, 24 Jul 2025 13:49:13 +0800 Subject: [PATCH] Fix unit test --- modules/indexer/issues/internal/model.go | 2 +- .../indexer/issues/internal/tests/tests.go | 20 ++++++++----------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/modules/indexer/issues/internal/model.go b/modules/indexer/issues/internal/model.go index f99df6c495c..8a251dd2abc 100644 --- a/modules/indexer/issues/internal/model.go +++ b/modules/indexer/issues/internal/model.go @@ -30,7 +30,7 @@ type IndexerData struct { LabelIDs []int64 `json:"label_ids"` NoLabel bool `json:"no_label"` // True if LabelIDs is empty MilestoneID int64 `json:"milestone_id"` - ProjectIDs []int64 `json:"project_ids"` + ProjectIDs []int64 `json:"project_id"` ProjectColumnID int64 `json:"project_board_id"` // the key should be kept as project_board_id to keep compatible PosterID int64 `json:"poster_id"` AssigneeID int64 `json:"assignee_id"` diff --git a/modules/indexer/issues/internal/tests/tests.go b/modules/indexer/issues/internal/tests/tests.go index 97a7ca1fab9..761b269f30a 100644 --- a/modules/indexer/issues/internal/tests/tests.go +++ b/modules/indexer/issues/internal/tests/tests.go @@ -312,9 +312,7 @@ var cases = []*testIndexerCase{ Expected: func(t *testing.T, data map[int64]*internal.IndexerData, result *internal.SearchResult) { assert.Len(t, result.Hits, 5) for _, v := range result.Hits { - if len(data[v.ID].ProjectIDs) > 0 { - assert.Equal(t, int64(1), data[v.ID].ProjectIDs[0]) - } + assert.Contains(t, data[v.ID].ProjectIDs, int64(1)) } assert.Equal(t, countIndexerData(data, func(v *internal.IndexerData) bool { if len(data[v.ID].ProjectIDs) > 0 { @@ -333,18 +331,12 @@ var cases = []*testIndexerCase{ ProjectIDs: []int64{0}, }, Expected: func(t *testing.T, data map[int64]*internal.IndexerData, result *internal.SearchResult) { - assert.Len(t, result.Hits, 5) + assert.Len(t, result.Hits, 0) for _, v := range result.Hits { if len(data[v.ID].ProjectIDs) > 0 { - assert.Equal(t, int64(0), data[v.ID].ProjectIDs[0]) + assert.Equal(t, int64(1), data[v.ID].ProjectIDs[0]) } } - assert.Equal(t, countIndexerData(data, func(v *internal.IndexerData) bool { - if len(data[v.ID].ProjectIDs) > 0 { - return v.ProjectIDs[0] == 1 - } - return false - }), result.Total) }, }, { @@ -717,6 +709,10 @@ func generateDefaultIndexerData() []*internal.IndexerData { for i := range subscriberIDs { subscriberIDs[i] = int64(i) + 1 // SubscriberID should not be 0 } + projectIDs := make([]int64, id%5) + for i := range projectIDs { + projectIDs[i] = int64(i) + 1 // projectID should not be 0 + } data = append(data, &internal.IndexerData{ ID: id, @@ -730,7 +726,7 @@ func generateDefaultIndexerData() []*internal.IndexerData { LabelIDs: labelIDs, NoLabel: len(labelIDs) == 0, MilestoneID: issueIndex % 4, - ProjectIDs: []int64{issueIndex % 5}, + ProjectIDs: projectIDs, ProjectColumnID: issueIndex % 6, PosterID: id%10 + 1, // PosterID should not be 0 AssigneeID: issueIndex % 10,