github/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-08-09 09:53:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: return ApiError instead of Error from projects methods

Browse Source
This commit is contained in:
Dinesh Salunke 2025-06-24 07:40:08 +05:30
parent 68ea867522
commit 596dcc01b5
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
routers/api/v1/projects/project.go
View File

@ -36,19 +36,19 @@ func innerCreateProject(ctx *context.APIContext, projectType project_model.Type)
} }
if err := project_model.NewProject(ctx, project); err != nil { if err := project_model.NewProject(ctx, project); err != nil {
ctx.Error(http.StatusInternalServerError, "NewProject", err) ctx.APIErrorInternal(err)
return return
} }
project, err := project_model.GetProjectByID(ctx, project.ID) project, err := project_model.GetProjectByID(ctx, project.ID)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "NewProject", err) ctx.APIErrorInternal(err)
return return
} }
projectResponse, err := convert.ToAPIProject(ctx, project) projectResponse, err := convert.ToAPIProject(ctx, project)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "NewProject", err) ctx.APIErrorInternal(err)
return return
} }
@ -161,16 +161,16 @@ func GetProject(ctx *context.APIContext) {
project, err := project_model.GetProjectByID(ctx, ctx.FormInt64(":id")) project, err := project_model.GetProjectByID(ctx, ctx.FormInt64(":id"))
if err != nil { if err != nil {
if project_model.IsErrProjectNotExist(err) { if project_model.IsErrProjectNotExist(err) {
ctx.NotFound() ctx.APIError(http.StatusNotFound, err)
} else { } else {
ctx.Error(http.StatusInternalServerError, "GetProjectByID", err) ctx.APIErrorInternal(err)
} }
return return
} }
projectResponse, err := convert.ToAPIProject(ctx, project) projectResponse, err := convert.ToAPIProject(ctx, project)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "GetProjectByID", err) ctx.APIErrorInternal(err)
return return
} }
ctx.JSON(http.StatusOK, projectResponse) ctx.JSON(http.StatusOK, projectResponse)
@ -205,9 +205,9 @@ func UpdateProject(ctx *context.APIContext) {
project, err := project_model.GetProjectByID(ctx, ctx.FormInt64("id")) project, err := project_model.GetProjectByID(ctx, ctx.FormInt64("id"))
if err != nil { if err != nil {
if project_model.IsErrProjectNotExist(err) { if project_model.IsErrProjectNotExist(err) {
ctx.NotFound() ctx.APIError(http.StatusNotFound, err)
} else { } else {
ctx.Error(http.StatusInternalServerError, "UpdateProject", err) ctx.APIErrorInternal(err)
} }
return return
} }
@ -220,12 +220,12 @@ func UpdateProject(ctx *context.APIContext) {
err = project_model.UpdateProject(ctx, project) err = project_model.UpdateProject(ctx, project)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "UpdateProject", err) ctx.APIErrorInternal(err)
return return
} }
projectResponse, err := convert.ToAPIProject(ctx, project) projectResponse, err := convert.ToAPIProject(ctx, project)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "UpdateProject", err) ctx.APIErrorInternal(err)
return return
} }
ctx.JSON(http.StatusOK, projectResponse) ctx.JSON(http.StatusOK, projectResponse)
@ -250,7 +250,7 @@ func DeleteProject(ctx *context.APIContext) {
// "$ref": "#/responses/notFound" // "$ref": "#/responses/notFound"
if err := project_model.DeleteProjectByID(ctx, ctx.FormInt64(":id")); err != nil { if err := project_model.DeleteProjectByID(ctx, ctx.FormInt64(":id")); err != nil {
ctx.Error(http.StatusInternalServerError, "DeleteProjectByID", err) ctx.APIErrorInternal(err)
return return
} }
@ -290,7 +290,7 @@ func ListUserProjects(ctx *context.APIContext) {
ListOptions: db.ListOptions{Page: ctx.FormInt("page")}, ListOptions: db.ListOptions{Page: ctx.FormInt("page")},
}) })
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ListUserProjets", err) ctx.APIErrorInternal(err)
return return
} }
@ -299,7 +299,7 @@ func ListUserProjects(ctx *context.APIContext) {
apiProjects, err := convert.ToAPIProjectList(ctx, projects) apiProjects, err := convert.ToAPIProjectList(ctx, projects)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ListUserProjects", err) ctx.APIErrorInternal(err)
return return
} }
@ -344,7 +344,7 @@ func ListOrgProjects(ctx *context.APIContext) {
Type: project_model.TypeOrganization, Type: project_model.TypeOrganization,
}) })
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ListOrgProjects", err) ctx.APIErrorInternal(err)
return return
} }
@ -353,7 +353,7 @@ func ListOrgProjects(ctx *context.APIContext) {
apiProjects, err := convert.ToAPIProjectList(ctx, projects) apiProjects, err := convert.ToAPIProjectList(ctx, projects)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ListOrgProjects", err) ctx.APIErrorInternal(err)
return return
} }
@ -405,7 +405,7 @@ func ListRepoProjects(ctx *context.APIContext) {
ListOptions: db.ListOptions{Page: page}, ListOptions: db.ListOptions{Page: page},
}) })
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ListRepoProjects", err) ctx.APIErrorInternal(err)
return return
} }
@ -414,7 +414,7 @@ func ListRepoProjects(ctx *context.APIContext) {
apiProjects, err := convert.ToAPIProjectList(ctx, projects) apiProjects, err := convert.ToAPIProjectList(ctx, projects)
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "ListRepoProjects", err) ctx.APIErrorInternal(err)
return return
} }