From 804022bdb54116144102b9052c18682bd4397840 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Fri, 18 Jul 2025 21:13:10 -0700 Subject: [PATCH] Fix test --- models/repo/release.go | 1 + models/user/main_test.go | 9 ++++++++- services/issue/comments_test.go | 4 +++- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/models/repo/release.go b/models/repo/release.go index 59f4caf5aa9..b3aae97560c 100644 --- a/models/repo/release.go +++ b/models/repo/release.go @@ -378,6 +378,7 @@ func GetReleaseAttachments(ctx context.Context, rels ...*Release) (err error) { err = db.GetEngine(ctx). Asc("release_id", "name"). In("release_id", sortedRels.ID). + And("status = ?", db.FileStatusNormal). Find(&attachments) if err != nil { return err diff --git a/models/user/main_test.go b/models/user/main_test.go index a626d323a71..2ca502bbeaa 100644 --- a/models/user/main_test.go +++ b/models/user/main_test.go @@ -7,6 +7,8 @@ import ( "testing" "code.gitea.io/gitea/models/unittest" + "code.gitea.io/gitea/modules/setting" + "code.gitea.io/gitea/services/attachment" _ "code.gitea.io/gitea/models" _ "code.gitea.io/gitea/models/actions" @@ -15,5 +17,10 @@ import ( ) func TestMain(m *testing.M) { - unittest.MainTest(m) + unittest.MainTest(m, &unittest.TestOptions{ + SetUp: func() error { + setting.LoadQueueSettings() + return attachment.Init() + }, + }) } diff --git a/services/issue/comments_test.go b/services/issue/comments_test.go index 2e548bc3cbe..4088bd1020d 100644 --- a/services/issue/comments_test.go +++ b/services/issue/comments_test.go @@ -34,5 +34,7 @@ func Test_DeleteCommentWithReview(t *testing.T) { // the review should be deleted as well unittest.AssertNotExistsBean(t, &issues_model.Review{ID: review.ID}) // the attachment should be deleted as well - unittest.AssertNotExistsBean(t, &repo_model.Attachment{ID: comment.Attachments[0].ID}) + newAttachment, err := repo_model.GetAttachmentByID(t.Context(), comment.Attachments[0].ID) + assert.Error(t, err) + assert.Nil(t, newAttachment) }