From 061d81788d73c493ea144d526a9f16c9b1be4a11 Mon Sep 17 00:00:00 2001 From: NorthRealm <155140859+NorthRealm@users.noreply.github.com> Date: Wed, 23 Jul 2025 20:47:49 +0800 Subject: [PATCH 1/5] MOVE --- services/mailer/mail_issue_common.go | 8 ++-- services/mailer/mail_release.go | 2 +- services/mailer/mail_repo.go | 37 ++++++++++++++++- services/mailer/mail_team_invite.go | 2 +- services/mailer/mail_test.go | 32 +++++++-------- services/mailer/mail_user.go | 41 ++----------------- services/mailer/mail_workflow_run.go | 5 ++- templates/mail/{ => org}/team_invite.tmpl | 0 .../actions}/workflow_run.devtest.yml | 0 .../actions}/workflow_run.tmpl | 0 .../mail/{notify => repo}/collaborator.tmpl | 0 templates/mail/{ => repo}/issue/assigned.tmpl | 0 templates/mail/{ => repo}/issue/default.tmpl | 0 templates/mail/{ => repo}/release.tmpl | 0 .../repo_transfer.tmpl => repo/transfer.tmpl} | 0 .../mail/{ => user}/auth/activate.devtest.yml | 0 templates/mail/{ => user}/auth/activate.tmpl | 0 .../mail/user/auth/activate_email.devtest.yml | 3 ++ .../mail/{ => user}/auth/activate_email.tmpl | 0 .../user/auth/register_notify.devtest.yml | 2 + .../mail/{ => user}/auth/register_notify.tmpl | 0 .../mail/user/auth/reset_passwd.devtest.yml | 3 ++ .../mail/{ => user}/auth/reset_passwd.tmpl | 0 23 files changed, 73 insertions(+), 62 deletions(-) rename templates/mail/{ => org}/team_invite.tmpl (100%) rename templates/mail/{notify => repo/actions}/workflow_run.devtest.yml (100%) rename templates/mail/{notify => repo/actions}/workflow_run.tmpl (100%) rename templates/mail/{notify => repo}/collaborator.tmpl (100%) rename templates/mail/{ => repo}/issue/assigned.tmpl (100%) rename templates/mail/{ => repo}/issue/default.tmpl (100%) rename templates/mail/{ => repo}/release.tmpl (100%) rename templates/mail/{notify/repo_transfer.tmpl => repo/transfer.tmpl} (100%) rename templates/mail/{ => user}/auth/activate.devtest.yml (100%) rename templates/mail/{ => user}/auth/activate.tmpl (100%) create mode 100644 templates/mail/user/auth/activate_email.devtest.yml rename templates/mail/{ => user}/auth/activate_email.tmpl (100%) create mode 100644 templates/mail/user/auth/register_notify.devtest.yml rename templates/mail/{ => user}/auth/register_notify.tmpl (100%) create mode 100644 templates/mail/user/auth/reset_passwd.devtest.yml rename templates/mail/{ => user}/auth/reset_passwd.tmpl (100%) diff --git a/services/mailer/mail_issue_common.go b/services/mailer/mail_issue_common.go index a34d8a68c97..bfff706abb4 100644 --- a/services/mailer/mail_issue_common.go +++ b/services/mailer/mail_issue_common.go @@ -260,18 +260,18 @@ func actionToTemplate(issue *issues_model.Issue, actionType activities_model.Act } } - template = typeName + "/" + name + template = "repo/" + typeName + "/" + name ok := LoadedTemplates().BodyTemplates.Lookup(template) != nil if !ok && typeName != "issue" { - template = "issue/" + name + template = "repo/issue/" + name ok = LoadedTemplates().BodyTemplates.Lookup(template) != nil } if !ok { - template = typeName + "/default" + template = "repo/" + typeName + "/default" ok = LoadedTemplates().BodyTemplates.Lookup(template) != nil } if !ok { - template = "issue/default" + template = "repo/issue/default" } return typeName, name, template } diff --git a/services/mailer/mail_release.go b/services/mailer/mail_release.go index fd97fb53124..248cf0ab909 100644 --- a/services/mailer/mail_release.go +++ b/services/mailer/mail_release.go @@ -19,7 +19,7 @@ import ( sender_service "code.gitea.io/gitea/services/mailer/sender" ) -const tplNewReleaseMail templates.TplName = "release" +const tplNewReleaseMail templates.TplName = "repo/release" func generateMessageIDForRelease(release *repo_model.Release) string { return fmt.Sprintf("<%s/releases/%d@%s>", release.Repo.FullName(), release.ID, setting.Domain) diff --git a/services/mailer/mail_repo.go b/services/mailer/mail_repo.go index 1ec7995ab94..f2b42ba3f53 100644 --- a/services/mailer/mail_repo.go +++ b/services/mailer/mail_repo.go @@ -11,13 +11,17 @@ import ( "code.gitea.io/gitea/models/organization" repo_model "code.gitea.io/gitea/models/repo" user_model "code.gitea.io/gitea/models/user" + "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" "code.gitea.io/gitea/modules/templates" "code.gitea.io/gitea/modules/translation" sender_service "code.gitea.io/gitea/services/mailer/sender" ) -const mailRepoTransferNotify templates.TplName = "notify/repo_transfer" +const ( + mailNotifyCollaborator templates.TplName = "repo/collaborator" + mailRepoTransferNotify templates.TplName = "repo/transfer" +) // SendRepoTransferNotifyMail triggers a notification e-mail when a pending repository transfer was created func SendRepoTransferNotifyMail(ctx context.Context, doer, newOwner *user_model.User, repo *repo_model.Repository) error { @@ -91,3 +95,34 @@ func sendRepoTransferNotifyMailPerLang(lang string, newOwner, doer *user_model.U return nil } + +// SendCollaboratorMail sends mail notification to new collaborator. +func SendCollaboratorMail(u, doer *user_model.User, repo *repo_model.Repository) { + if setting.MailService == nil || !u.IsActive { + // No mail service configured OR the user is inactive + return + } + locale := translation.NewLocale(u.Language) + repoName := repo.FullName() + + subject := locale.TrString("mail.repo.collaborator.added.subject", doer.DisplayName(), repoName) + data := map[string]any{ + "locale": locale, + "Subject": subject, + "RepoName": repoName, + "Link": repo.HTMLURL(), + "Language": locale.Language(), + } + + var content bytes.Buffer + + if err := LoadedTemplates().BodyTemplates.ExecuteTemplate(&content, string(mailNotifyCollaborator), data); err != nil { + log.Error("Template: %v", err) + return + } + + msg := sender_service.NewMessage(u.EmailTo(), subject, content.String()) + msg.Info = fmt.Sprintf("UID: %d, add collaborator", u.ID) + + SendAsync(msg) +} diff --git a/services/mailer/mail_team_invite.go b/services/mailer/mail_team_invite.go index 034dc14e3d7..4819f299425 100644 --- a/services/mailer/mail_team_invite.go +++ b/services/mailer/mail_team_invite.go @@ -19,7 +19,7 @@ import ( sender_service "code.gitea.io/gitea/services/mailer/sender" ) -const tplTeamInviteMail templates.TplName = "team_invite" +const tplTeamInviteMail templates.TplName = "org/team_invite" // MailTeamInvite sends team invites func MailTeamInvite(ctx context.Context, inviter *user_model.User, team *org_model.Team, invite *org_model.TeamInvite) error { diff --git a/services/mailer/mail_test.go b/services/mailer/mail_test.go index 24f5d39d50d..b4e95fa144b 100644 --- a/services/mailer/mail_test.go +++ b/services/mailer/mail_test.go @@ -116,7 +116,7 @@ func TestComposeIssueComment(t *testing.T) { setting.IncomingEmail.Enabled = true defer func() { setting.IncomingEmail.Enabled = false }() - prepareMailTemplates("issue/comment", subjectTpl, bodyTpl) + prepareMailTemplates("repo/issue/comment", subjectTpl, bodyTpl) recipients := []*user_model.User{{Name: "Test", Email: "test@gitea.com"}, {Name: "Test2", Email: "test2@gitea.com"}} msgs, err := composeIssueCommentMessages(t.Context(), &mailComment{ @@ -161,7 +161,7 @@ func TestComposeIssueComment(t *testing.T) { func TestMailMentionsComment(t *testing.T) { doer, _, issue, comment := prepareMailerTest(t) comment.Poster = doer - prepareMailTemplates("issue/comment", subjectTpl, bodyTpl) + prepareMailTemplates("repo/issue/comment", subjectTpl, bodyTpl) mails := 0 defer test.MockVariableValue(&SendAsync, func(msgs ...*sender_service.Message) { @@ -176,7 +176,7 @@ func TestMailMentionsComment(t *testing.T) { func TestComposeIssueMessage(t *testing.T) { doer, _, issue, _ := prepareMailerTest(t) - prepareMailTemplates("issue/new", subjectTpl, bodyTpl) + prepareMailTemplates("repo/issue/new", subjectTpl, bodyTpl) recipients := []*user_model.User{{Name: "Test", Email: "test@gitea.com"}, {Name: "Test2", Email: "test2@gitea.com"}} msgs, err := composeIssueCommentMessages(t.Context(), &mailComment{ Issue: issue, Doer: doer, ActionType: activities_model.ActionCreateIssue, @@ -205,14 +205,14 @@ func TestTemplateSelection(t *testing.T) { doer, repo, issue, comment := prepareMailerTest(t) recipients := []*user_model.User{{Name: "Test", Email: "test@gitea.com"}} - prepareMailTemplates("issue/default", "issue/default/subject", "issue/default/body") + prepareMailTemplates("repo/issue/default", "repo/issue/default/subject", "repo/issue/default/body") - texttmpl.Must(LoadedTemplates().SubjectTemplates.New("issue/new").Parse("issue/new/subject")) - texttmpl.Must(LoadedTemplates().SubjectTemplates.New("pull/comment").Parse("pull/comment/subject")) - texttmpl.Must(LoadedTemplates().SubjectTemplates.New("issue/close").Parse("")) // Must default to a fallback subject - template.Must(LoadedTemplates().BodyTemplates.New("issue/new").Parse("issue/new/body")) - template.Must(LoadedTemplates().BodyTemplates.New("pull/comment").Parse("pull/comment/body")) - template.Must(LoadedTemplates().BodyTemplates.New("issue/close").Parse("issue/close/body")) + texttmpl.Must(LoadedTemplates().SubjectTemplates.New("repo/issue/new").Parse("repo/issue/new/subject")) + texttmpl.Must(LoadedTemplates().SubjectTemplates.New("repo/pull/comment").Parse("repo/pull/comment/subject")) + texttmpl.Must(LoadedTemplates().SubjectTemplates.New("repo/issue/close").Parse("")) // Must default to a fallback subject + template.Must(LoadedTemplates().BodyTemplates.New("repo/issue/new").Parse("repo/issue/new/body")) + template.Must(LoadedTemplates().BodyTemplates.New("repo/pull/comment").Parse("repo/pull/comment/body")) + template.Must(LoadedTemplates().BodyTemplates.New("repo/issue/close").Parse("repo/issue/close/body")) expect := func(t *testing.T, msg *sender_service.Message, expSubject, expBody string) { subject := msg.ToMessage().GetGenHeader("Subject") @@ -227,13 +227,13 @@ func TestTemplateSelection(t *testing.T) { Issue: issue, Doer: doer, ActionType: activities_model.ActionCreateIssue, Content: "test body", }, recipients, false, "TestTemplateSelection") - expect(t, msg, "issue/new/subject", "issue/new/body") + expect(t, msg, "repo/issue/new/subject", "repo/issue/new/body") msg = testComposeIssueCommentMessage(t, &mailComment{ Issue: issue, Doer: doer, ActionType: activities_model.ActionCommentIssue, Content: "test body", Comment: comment, }, recipients, false, "TestTemplateSelection") - expect(t, msg, "issue/default/subject", "issue/default/body") + expect(t, msg, "repo/issue/default/subject", "repo/issue/default/body") pull := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2, Repo: repo, Poster: doer}) comment = unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: 4, Issue: pull}) @@ -241,13 +241,13 @@ func TestTemplateSelection(t *testing.T) { Issue: pull, Doer: doer, ActionType: activities_model.ActionCommentPull, Content: "test body", Comment: comment, }, recipients, false, "TestTemplateSelection") - expect(t, msg, "pull/comment/subject", "pull/comment/body") + expect(t, msg, "repo/pull/comment/subject", "repo/pull/comment/body") msg = testComposeIssueCommentMessage(t, &mailComment{ Issue: issue, Doer: doer, ActionType: activities_model.ActionCloseIssue, Content: "test body", Comment: comment, }, recipients, false, "TestTemplateSelection") - expect(t, msg, "Re: [user2/repo1] issue1 (#1)", "issue/close/body") + expect(t, msg, "Re: [user2/repo1] issue1 (#1)", "repo/issue/close/body") } func TestTemplateServices(t *testing.T) { @@ -257,7 +257,7 @@ func TestTemplateServices(t *testing.T) { expect := func(t *testing.T, issue *issues_model.Issue, comment *issues_model.Comment, doer *user_model.User, actionType activities_model.ActionType, fromMention bool, tplSubject, tplBody, expSubject, expBody string, ) { - prepareMailTemplates("issue/default", tplSubject, tplBody) + prepareMailTemplates("repo/issue/default", tplSubject, tplBody) recipients := []*user_model.User{{Name: "Test", Email: "test@gitea.com"}} msg := testComposeIssueCommentMessage(t, &mailComment{ Issue: issue, Doer: doer, ActionType: actionType, @@ -524,7 +524,7 @@ func TestEmbedBase64Images(t *testing.T) { att2ImgBase64 := fmt.Sprintf(``, att2Base64) t.Run("ComposeMessage", func(t *testing.T) { - prepareMailTemplates("issue/new", subjectTpl, bodyTpl) + prepareMailTemplates("repo/issue/new", subjectTpl, bodyTpl) issue.Content = fmt.Sprintf(`MSG-BEFORE MSG-AFTER`, att1.UUID) require.NoError(t, issues_model.UpdateIssueCols(t.Context(), issue, "content")) diff --git a/services/mailer/mail_user.go b/services/mailer/mail_user.go index 68df81f6a3a..867a8b2a8f4 100644 --- a/services/mailer/mail_user.go +++ b/services/mailer/mail_user.go @@ -7,7 +7,6 @@ import ( "bytes" "fmt" - repo_model "code.gitea.io/gitea/models/repo" user_model "code.gitea.io/gitea/models/user" "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" @@ -18,11 +17,10 @@ import ( ) const ( - mailAuthActivate templates.TplName = "auth/activate" - mailAuthActivateEmail templates.TplName = "auth/activate_email" - mailAuthResetPassword templates.TplName = "auth/reset_passwd" - mailAuthRegisterNotify templates.TplName = "auth/register_notify" - mailNotifyCollaborator templates.TplName = "notify/collaborator" + mailAuthActivate templates.TplName = "user/auth/activate" + mailAuthActivateEmail templates.TplName = "user/auth/activate_email" + mailAuthResetPassword templates.TplName = "user/auth/reset_passwd" + mailAuthRegisterNotify templates.TplName = "user/auth/register_notify" ) // sendUserMail sends a mail to the user @@ -128,34 +126,3 @@ func SendRegisterNotifyMail(u *user_model.User) { SendAsync(msg) } - -// SendCollaboratorMail sends mail notification to new collaborator. -func SendCollaboratorMail(u, doer *user_model.User, repo *repo_model.Repository) { - if setting.MailService == nil || !u.IsActive { - // No mail service configured OR the user is inactive - return - } - locale := translation.NewLocale(u.Language) - repoName := repo.FullName() - - subject := locale.TrString("mail.repo.collaborator.added.subject", doer.DisplayName(), repoName) - data := map[string]any{ - "locale": locale, - "Subject": subject, - "RepoName": repoName, - "Link": repo.HTMLURL(), - "Language": locale.Language(), - } - - var content bytes.Buffer - - if err := LoadedTemplates().BodyTemplates.ExecuteTemplate(&content, string(mailNotifyCollaborator), data); err != nil { - log.Error("Template: %v", err) - return - } - - msg := sender_service.NewMessage(u.EmailTo(), subject, content.String()) - msg.Info = fmt.Sprintf("UID: %d, add collaborator", u.ID) - - SendAsync(msg) -} diff --git a/services/mailer/mail_workflow_run.go b/services/mailer/mail_workflow_run.go index 29b3abda8ee..da791894a53 100644 --- a/services/mailer/mail_workflow_run.go +++ b/services/mailer/mail_workflow_run.go @@ -15,12 +15,13 @@ import ( "code.gitea.io/gitea/modules/base" "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" + "code.gitea.io/gitea/modules/templates" "code.gitea.io/gitea/modules/translation" "code.gitea.io/gitea/services/convert" sender_service "code.gitea.io/gitea/services/mailer/sender" ) -const tplWorkflowRun = "notify/workflow_run" +const tplWorkflowRun templates.TplName = "repo/actions/workflow_run" type convertedWorkflowJob struct { HTMLURL string @@ -103,7 +104,7 @@ func composeAndSendActionsWorkflowRunStatusEmail(ctx context.Context, repo *repo runStatusText = "All jobs have been cancelled" } var mailBody bytes.Buffer - if err := LoadedTemplates().BodyTemplates.ExecuteTemplate(&mailBody, tplWorkflowRun, map[string]any{ + if err := LoadedTemplates().BodyTemplates.ExecuteTemplate(&mailBody, string(tplWorkflowRun), map[string]any{ "Subject": subject, "Repo": repo, "Run": run, diff --git a/templates/mail/team_invite.tmpl b/templates/mail/org/team_invite.tmpl similarity index 100% rename from templates/mail/team_invite.tmpl rename to templates/mail/org/team_invite.tmpl diff --git a/templates/mail/notify/workflow_run.devtest.yml b/templates/mail/repo/actions/workflow_run.devtest.yml similarity index 100% rename from templates/mail/notify/workflow_run.devtest.yml rename to templates/mail/repo/actions/workflow_run.devtest.yml diff --git a/templates/mail/notify/workflow_run.tmpl b/templates/mail/repo/actions/workflow_run.tmpl similarity index 100% rename from templates/mail/notify/workflow_run.tmpl rename to templates/mail/repo/actions/workflow_run.tmpl diff --git a/templates/mail/notify/collaborator.tmpl b/templates/mail/repo/collaborator.tmpl similarity index 100% rename from templates/mail/notify/collaborator.tmpl rename to templates/mail/repo/collaborator.tmpl diff --git a/templates/mail/issue/assigned.tmpl b/templates/mail/repo/issue/assigned.tmpl similarity index 100% rename from templates/mail/issue/assigned.tmpl rename to templates/mail/repo/issue/assigned.tmpl diff --git a/templates/mail/issue/default.tmpl b/templates/mail/repo/issue/default.tmpl similarity index 100% rename from templates/mail/issue/default.tmpl rename to templates/mail/repo/issue/default.tmpl diff --git a/templates/mail/release.tmpl b/templates/mail/repo/release.tmpl similarity index 100% rename from templates/mail/release.tmpl rename to templates/mail/repo/release.tmpl diff --git a/templates/mail/notify/repo_transfer.tmpl b/templates/mail/repo/transfer.tmpl similarity index 100% rename from templates/mail/notify/repo_transfer.tmpl rename to templates/mail/repo/transfer.tmpl diff --git a/templates/mail/auth/activate.devtest.yml b/templates/mail/user/auth/activate.devtest.yml similarity index 100% rename from templates/mail/auth/activate.devtest.yml rename to templates/mail/user/auth/activate.devtest.yml diff --git a/templates/mail/auth/activate.tmpl b/templates/mail/user/auth/activate.tmpl similarity index 100% rename from templates/mail/auth/activate.tmpl rename to templates/mail/user/auth/activate.tmpl diff --git a/templates/mail/user/auth/activate_email.devtest.yml b/templates/mail/user/auth/activate_email.devtest.yml new file mode 100644 index 00000000000..f5519a6f6c0 --- /dev/null +++ b/templates/mail/user/auth/activate_email.devtest.yml @@ -0,0 +1,3 @@ +DisplayName: User Display Name +Code: The-Activation-Code +ActiveCodeLives: 24h diff --git a/templates/mail/auth/activate_email.tmpl b/templates/mail/user/auth/activate_email.tmpl similarity index 100% rename from templates/mail/auth/activate_email.tmpl rename to templates/mail/user/auth/activate_email.tmpl diff --git a/templates/mail/user/auth/register_notify.devtest.yml b/templates/mail/user/auth/register_notify.devtest.yml new file mode 100644 index 00000000000..8c9d6837d45 --- /dev/null +++ b/templates/mail/user/auth/register_notify.devtest.yml @@ -0,0 +1,2 @@ +DisplayName: User Display Name +Username: Username diff --git a/templates/mail/auth/register_notify.tmpl b/templates/mail/user/auth/register_notify.tmpl similarity index 100% rename from templates/mail/auth/register_notify.tmpl rename to templates/mail/user/auth/register_notify.tmpl diff --git a/templates/mail/user/auth/reset_passwd.devtest.yml b/templates/mail/user/auth/reset_passwd.devtest.yml new file mode 100644 index 00000000000..4c73d6b952d --- /dev/null +++ b/templates/mail/user/auth/reset_passwd.devtest.yml @@ -0,0 +1,3 @@ +DisplayName: User Display Name +Code: The-Activation-Code +ResetPwdCodeLives: 24h diff --git a/templates/mail/auth/reset_passwd.tmpl b/templates/mail/user/auth/reset_passwd.tmpl similarity index 100% rename from templates/mail/auth/reset_passwd.tmpl rename to templates/mail/user/auth/reset_passwd.tmpl From 9993fc69e99539878b6d2ec89f93ebe3e88d9a9b Mon Sep 17 00:00:00 2001 From: NorthRealm <155140859+NorthRealm@users.noreply.github.com> Date: Wed, 23 Jul 2025 21:38:47 +0800 Subject: [PATCH 2/5] MOVE --- templates/mail/org/team_invite.devtest.yml | 13 +++++++++++++ .../mail/repo/actions/workflow_run.devtest.yml | 8 ++++---- templates/mail/repo/collaborator.devtest.yml | 3 +++ templates/mail/repo/collaborator.tmpl | 5 +---- templates/mail/repo/issue/assigned.devtest.yml | 11 +++++++++++ templates/mail/repo/issue/assigned.tmpl | 5 +---- templates/mail/repo/issue/default.tmpl | 13 ++++++------- templates/mail/repo/release.tmpl | 13 ++++++------- templates/mail/repo/transfer.devtest.yml | 3 +++ templates/mail/repo/transfer.tmpl | 12 +++++++----- templates/mail/user/auth/activate_email.devtest.yml | 1 + templates/mail/user/auth/reset_passwd.devtest.yml | 2 +- 12 files changed, 57 insertions(+), 32 deletions(-) create mode 100644 templates/mail/org/team_invite.devtest.yml create mode 100644 templates/mail/repo/collaborator.devtest.yml create mode 100644 templates/mail/repo/issue/assigned.devtest.yml create mode 100644 templates/mail/repo/transfer.devtest.yml diff --git a/templates/mail/org/team_invite.devtest.yml b/templates/mail/org/team_invite.devtest.yml new file mode 100644 index 00000000000..dc51a74d641 --- /dev/null +++ b/templates/mail/org/team_invite.devtest.yml @@ -0,0 +1,13 @@ +Inviter: + DisplayName: Inviter Display Name + +Team: + Name: Team name + +Organization: + DisplayName: Organization Display Name + +InviteURL: http://localhost/org/team/invite + +Invite: + Email: invited@example.com diff --git a/templates/mail/repo/actions/workflow_run.devtest.yml b/templates/mail/repo/actions/workflow_run.devtest.yml index 1e285be328b..3d93ad45a3a 100644 --- a/templates/mail/repo/actions/workflow_run.devtest.yml +++ b/templates/mail/repo/actions/workflow_run.devtest.yml @@ -1,10 +1,10 @@ -RunStatusText: run status text .... +RunStatusText: Jobs status aggregation Repo: - FullName: RepoName + FullName: Repo/Name Run: - WorkflowID: WorkflowID + WorkflowID: workflow.yml HTMLURL: http://localhost/run/1 Jobs: @@ -13,6 +13,6 @@ Jobs: Attempt: 1 HTMLURL: http://localhost/job/1 - Name: Job-Name-2 - Status: failed + Status: failure Attempt: 2 HTMLURL: http://localhost/job/2 diff --git a/templates/mail/repo/collaborator.devtest.yml b/templates/mail/repo/collaborator.devtest.yml new file mode 100644 index 00000000000..8d8f2b27333 --- /dev/null +++ b/templates/mail/repo/collaborator.devtest.yml @@ -0,0 +1,3 @@ +Subject: Collaborator added +Link: http://localhost +RepoName: Repo/Name diff --git a/templates/mail/repo/collaborator.tmpl b/templates/mail/repo/collaborator.tmpl index 9810c709842..3fe490e2211 100644 --- a/templates/mail/repo/collaborator.tmpl +++ b/templates/mail/repo/collaborator.tmpl @@ -1,16 +1,13 @@ - {{.Subject}}

{{.locale.Tr "mail.repo.collaborator.added.text"}} {{.RepoName}}

-
+

---
diff --git a/templates/mail/repo/issue/assigned.devtest.yml b/templates/mail/repo/issue/assigned.devtest.yml new file mode 100644 index 00000000000..69a5cce1b01 --- /dev/null +++ b/templates/mail/repo/issue/assigned.devtest.yml @@ -0,0 +1,11 @@ +Subject: Issue assigned +Link: http://localhost + +Issue: + Index: 1 + Repo: + FullName: Repo/Name + HTMLURL: http://localhost/issue + +Doer: + Name: DoerName diff --git a/templates/mail/repo/issue/assigned.tmpl b/templates/mail/repo/issue/assigned.tmpl index 5720319ee84..cdba7a0ad07 100644 --- a/templates/mail/repo/issue/assigned.tmpl +++ b/templates/mail/repo/issue/assigned.tmpl @@ -1,9 +1,6 @@ - {{.Subject}} @@ -18,7 +15,7 @@ {{.locale.Tr "mail.issue_assigned.issue" .Doer.Name $link $repo_url}} {{end}}

-
+

---
diff --git a/templates/mail/repo/issue/default.tmpl b/templates/mail/repo/issue/default.tmpl index 395b118d3ef..f06ce4ae243 100644 --- a/templates/mail/repo/issue/default.tmpl +++ b/templates/mail/repo/issue/default.tmpl @@ -6,7 +6,6 @@ @@ -50,12 +49,12 @@ {{end}}

-
-

- --- -
- {{.locale.Tr "mail.view_it_on" AppName}}. -

+ diff --git a/templates/mail/repo/transfer.devtest.yml b/templates/mail/repo/transfer.devtest.yml new file mode 100644 index 00000000000..e2ec67c6429 --- /dev/null +++ b/templates/mail/repo/transfer.devtest.yml @@ -0,0 +1,3 @@ +Subject: Repository transfer +Link: http://localhost +Repo: Repo/Name diff --git a/templates/mail/repo/transfer.tmpl b/templates/mail/repo/transfer.tmpl index 8c8b276484e..43083b97b73 100644 --- a/templates/mail/repo/transfer.tmpl +++ b/templates/mail/repo/transfer.tmpl @@ -10,10 +10,12 @@

{{.Subject}}. {{.locale.Tr "mail.repo.transfer.body" $url}}

-

- --- -
- {{.locale.Tr "mail.view_it_on" AppName}}. -

+ diff --git a/templates/mail/user/auth/activate_email.devtest.yml b/templates/mail/user/auth/activate_email.devtest.yml index f5519a6f6c0..41d1ae029f6 100644 --- a/templates/mail/user/auth/activate_email.devtest.yml +++ b/templates/mail/user/auth/activate_email.devtest.yml @@ -1,3 +1,4 @@ DisplayName: User Display Name Code: The-Activation-Code +Email: admin@example.com ActiveCodeLives: 24h diff --git a/templates/mail/user/auth/reset_passwd.devtest.yml b/templates/mail/user/auth/reset_passwd.devtest.yml index 4c73d6b952d..f4269ebeb7d 100644 --- a/templates/mail/user/auth/reset_passwd.devtest.yml +++ b/templates/mail/user/auth/reset_passwd.devtest.yml @@ -1,3 +1,3 @@ DisplayName: User Display Name -Code: The-Activation-Code +Code: The-Reset-Token ResetPwdCodeLives: 24h From d890db10c8a25bdffa4b740c89397166c3c0793a Mon Sep 17 00:00:00 2001 From: NorthRealm <155140859+NorthRealm@users.noreply.github.com> Date: Wed, 23 Jul 2025 21:43:21 +0800 Subject: [PATCH 3/5] MOVE --- templates/mail/repo/issue/default.tmpl | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/templates/mail/repo/issue/default.tmpl b/templates/mail/repo/issue/default.tmpl index f06ce4ae243..07320bc43ce 100644 --- a/templates/mail/repo/issue/default.tmpl +++ b/templates/mail/repo/issue/default.tmpl @@ -6,10 +6,6 @@ @@ -62,8 +58,8 @@ {{- range .ReviewComments}}
{{$.locale.Tr "mail.issue.in_tree_path" .TreePath}} -
- 
{{.Patch}}
+
+ 
{{.Patch}}
{{.RenderedContent}}
{{end -}} From 5c6c94e6a729a4cf71f51921e3e597b99f0e2dae Mon Sep 17 00:00:00 2001 From: NorthRealm <155140859+NorthRealm@users.noreply.github.com> Date: Thu, 24 Jul 2025 01:14:42 +0800 Subject: [PATCH 4/5] UPDATE --- options/locale/locale_en-US.ini | 8 ++++ services/mailer/mail_workflow_run.go | 41 ++++++++++--------- .../repo/actions/workflow_run.devtest.yml | 2 + templates/mail/repo/actions/workflow_run.tmpl | 2 +- 4 files changed, 33 insertions(+), 20 deletions(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index c1a3d37037f..ff331b97714 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -550,6 +550,14 @@ repo.transfer.body = To accept or reject it visit %s or just ignore it. repo.collaborator.added.subject = %s added you to %s repo.collaborator.added.text = You have been added as a collaborator of repository: +repo.actions.run.failed = Run failed +repo.actions.run.succeeded = Run succeeded +repo.actions.run.cancelled = Run cancelled +repo.actions.jobs.all_succeeded = All jobs have succeeded +repo.actions.jobs.all_failed = All jobs have failed +repo.actions.jobs.some_not_successful = Some jobs were not successful +repo.actions.jobs.all_cancelled = All jobs have been cancelled + team_invite.subject = %[1]s has invited you to join the %[2]s organization team_invite.text_1 = %[1]s has invited you to join team %[2]s in organization %[3]s. team_invite.text_2 = Please click the following link to join the team: diff --git a/services/mailer/mail_workflow_run.go b/services/mailer/mail_workflow_run.go index da791894a53..664d1bd1654 100644 --- a/services/mailer/mail_workflow_run.go +++ b/services/mailer/mail_workflow_run.go @@ -8,6 +8,7 @@ import ( "context" "fmt" "sort" + "time" actions_model "code.gitea.io/gitea/models/actions" repo_model "code.gitea.io/gitea/models/repo" @@ -24,10 +25,11 @@ import ( const tplWorkflowRun templates.TplName = "repo/actions/workflow_run" type convertedWorkflowJob struct { - HTMLURL string - Status actions_model.Status - Name string - Attempt int64 + HTMLURL string + Name string + Status actions_model.Status + Attempt int64 + Duration time.Duration } func generateMessageIDForActionsWorkflowRunStatusEmail(repo *repo_model.Repository, run *actions_model.ActionRun) string { @@ -35,16 +37,15 @@ func generateMessageIDForActionsWorkflowRunStatusEmail(repo *repo_model.Reposito } func composeAndSendActionsWorkflowRunStatusEmail(ctx context.Context, repo *repo_model.Repository, run *actions_model.ActionRun, sender *user_model.User, recipients []*user_model.User) { - subject := "Run" + var subjectTrString string switch run.Status { case actions_model.StatusFailure: - subject += " failed" + subjectTrString = "mail.repo.actions.run.failed" case actions_model.StatusCancelled: - subject += " cancelled" + subjectTrString = "mail.repo.actions.run.cancelled" case actions_model.StatusSuccess: - subject += " succeeded" + subjectTrString = "mail.repo.actions.run.succeeded" } - subject = fmt.Sprintf("%s: %s (%s)", subject, run.WorkflowID, base.ShortSha(run.CommitSHA)) displayName := fromDisplayName(sender) messageID := generateMessageIDForActionsWorkflowRunStatusEmail(repo, run) metadataHeaders := generateMetadataHeaders(repo) @@ -75,10 +76,11 @@ func composeAndSendActionsWorkflowRunStatusEmail(ctx context.Context, repo *repo continue } convertedJobs = append(convertedJobs, convertedWorkflowJob{ - HTMLURL: converted0.HTMLURL, - Name: converted0.Name, - Status: job.Status, - Attempt: converted0.RunAttempt, + HTMLURL: converted0.HTMLURL, + Name: converted0.Name, + Status: job.Status, + Attempt: converted0.RunAttempt, + Duration: job.Duration(), }) } @@ -88,27 +90,28 @@ func composeAndSendActionsWorkflowRunStatusEmail(ctx context.Context, repo *repo } for lang, tos := range langMap { locale := translation.NewLocale(lang) - var runStatusText string + var runStatusTrString string switch run.Status { case actions_model.StatusSuccess: - runStatusText = "All jobs have succeeded" + runStatusTrString = "mail.repo.actions.jobs.all_succeeded" case actions_model.StatusFailure: - runStatusText = "All jobs have failed" + runStatusTrString = "mail.repo.actions.jobs.all_failed" for _, job := range jobs { if !job.Status.IsFailure() { - runStatusText = "Some jobs were not successful" + runStatusTrString = "mail.repo.actions.jobs.some_not_successful" break } } case actions_model.StatusCancelled: - runStatusText = "All jobs have been cancelled" + runStatusTrString = "mail.repo.actions.jobs.all_cancelled" } + subject := fmt.Sprintf("%s: %s (%s)", locale.TrString(subjectTrString), run.WorkflowID, base.ShortSha(run.CommitSHA)) var mailBody bytes.Buffer if err := LoadedTemplates().BodyTemplates.ExecuteTemplate(&mailBody, string(tplWorkflowRun), map[string]any{ "Subject": subject, "Repo": repo, "Run": run, - "RunStatusText": runStatusText, + "RunStatusText": locale.TrString(runStatusTrString), "Jobs": convertedJobs, "locale": locale, }); err != nil { diff --git a/templates/mail/repo/actions/workflow_run.devtest.yml b/templates/mail/repo/actions/workflow_run.devtest.yml index 3d93ad45a3a..a45b26a6eef 100644 --- a/templates/mail/repo/actions/workflow_run.devtest.yml +++ b/templates/mail/repo/actions/workflow_run.devtest.yml @@ -12,7 +12,9 @@ Jobs: Status: success Attempt: 1 HTMLURL: http://localhost/job/1 + Duration: 1h2m3s - Name: Job-Name-2 Status: failure Attempt: 2 HTMLURL: http://localhost/job/2 + Duration: 1h2m3s diff --git a/templates/mail/repo/actions/workflow_run.tmpl b/templates/mail/repo/actions/workflow_run.tmpl index f6dd8ad510e..619ee6fa20f 100644 --- a/templates/mail/repo/actions/workflow_run.tmpl +++ b/templates/mail/repo/actions/workflow_run.tmpl @@ -15,7 +15,7 @@ {{range $job := .Jobs}}
  • - {{$job.Status}}: {{$job.Name}}{{if gt $job.Attempt 1}}, Attempt #{{$job.Attempt}}{{end}} + {{$job.Status}}: {{$job.Name}}{{if gt $job.Attempt 1}}, Attempt #{{$job.Attempt}}{{end}}, {{$job.Duration}}
    • {{end}} From 3ff5727ecc01369fe6b17c3348bcbb3de0f12647 Mon Sep 17 00:00:00 2001 From: NorthRealm <155140859+NorthRealm@users.noreply.github.com> Date: Thu, 24 Jul 2025 19:49:42 +0800 Subject: [PATCH 5/5] UPDATE --- templates/mail/footer_gitea.tmpl | 6 ++++++ templates/mail/footer_view_on_gitea.tmpl | 12 ++++++++++++ templates/mail/org/team_invite.tmpl | 2 +- templates/mail/repo/collaborator.tmpl | 8 +------- templates/mail/repo/issue/assigned.tmpl | 8 +------- templates/mail/repo/issue/default.devtest.yml | 1 + templates/mail/repo/issue/default.tmpl | 8 +------- templates/mail/repo/release.tmpl | 8 +------- templates/mail/repo/transfer.tmpl | 8 +------- templates/mail/user/auth/activate.tmpl | 2 +- templates/mail/user/auth/activate_email.tmpl | 2 +- templates/mail/user/auth/register_notify.tmpl | 2 +- templates/mail/user/auth/reset_passwd.tmpl | 2 +- 13 files changed, 29 insertions(+), 40 deletions(-) create mode 100644 templates/mail/footer_gitea.tmpl create mode 100644 templates/mail/footer_view_on_gitea.tmpl create mode 100644 templates/mail/repo/issue/default.devtest.yml diff --git a/templates/mail/footer_gitea.tmpl b/templates/mail/footer_gitea.tmpl new file mode 100644 index 00000000000..6ec5bee0164 --- /dev/null +++ b/templates/mail/footer_gitea.tmpl @@ -0,0 +1,6 @@ + + + +

    © {{AppName}}

    + + diff --git a/templates/mail/footer_view_on_gitea.tmpl b/templates/mail/footer_view_on_gitea.tmpl new file mode 100644 index 00000000000..3625a58e5d8 --- /dev/null +++ b/templates/mail/footer_view_on_gitea.tmpl @@ -0,0 +1,12 @@ + + + +
    +

    + --- +
    + {{.locale.Tr "mail.view_it_on" AppName}}{{if .CanReply}} {{.locale.Tr "mail.reply"}}{{end}}. +

    +
    + + diff --git a/templates/mail/org/team_invite.tmpl b/templates/mail/org/team_invite.tmpl index cb0c0c0a50b..29dc9a37ae5 100644 --- a/templates/mail/org/team_invite.tmpl +++ b/templates/mail/org/team_invite.tmpl @@ -10,6 +10,6 @@

    {{.locale.Tr "mail.link_not_working_do_paste"}}

    {{.locale.Tr "mail.team_invite.text_3" .Invite.Email}}

    -

    © {{AppName}}

    + {{template "footer_gitea"}} diff --git a/templates/mail/repo/collaborator.tmpl b/templates/mail/repo/collaborator.tmpl index 3fe490e2211..7c3074561f6 100644 --- a/templates/mail/repo/collaborator.tmpl +++ b/templates/mail/repo/collaborator.tmpl @@ -7,12 +7,6 @@

    {{.locale.Tr "mail.repo.collaborator.added.text"}} {{.RepoName}}

    - + {{template "footer_view_on_gitea" .}} diff --git a/templates/mail/repo/issue/assigned.tmpl b/templates/mail/repo/issue/assigned.tmpl index cdba7a0ad07..80c60c7e729 100644 --- a/templates/mail/repo/issue/assigned.tmpl +++ b/templates/mail/repo/issue/assigned.tmpl @@ -15,12 +15,6 @@ {{.locale.Tr "mail.issue_assigned.issue" .Doer.Name $link $repo_url}} {{end}}

    - + {{template "footer_view_on_gitea" .}} diff --git a/templates/mail/repo/issue/default.devtest.yml b/templates/mail/repo/issue/default.devtest.yml new file mode 100644 index 00000000000..5a7953639bb --- /dev/null +++ b/templates/mail/repo/issue/default.devtest.yml @@ -0,0 +1 @@ +CanReply: true diff --git a/templates/mail/repo/issue/default.tmpl b/templates/mail/repo/issue/default.tmpl index 07320bc43ce..ba9b58bc862 100644 --- a/templates/mail/repo/issue/default.tmpl +++ b/templates/mail/repo/issue/default.tmpl @@ -75,12 +75,6 @@ {{end}}

    -
    -

    - --- -
    - {{.locale.Tr "mail.view_it_on" AppName}}{{if .CanReply}} {{.locale.Tr "mail.reply"}}{{end}}. -

    -
    + {{template "footer_view_on_gitea" .}} diff --git a/templates/mail/repo/release.tmpl b/templates/mail/repo/release.tmpl index 3172e6a19d7..95c63fb079b 100644 --- a/templates/mail/repo/release.tmpl +++ b/templates/mail/repo/release.tmpl @@ -49,12 +49,6 @@ {{end}}

    - + {{template "footer_view_on_gitea" .}} diff --git a/templates/mail/repo/transfer.tmpl b/templates/mail/repo/transfer.tmpl index 43083b97b73..9d3d24dd987 100644 --- a/templates/mail/repo/transfer.tmpl +++ b/templates/mail/repo/transfer.tmpl @@ -10,12 +10,6 @@

    {{.Subject}}. {{.locale.Tr "mail.repo.transfer.body" $url}}

    - + {{template "footer_view_on_gitea" .}} diff --git a/templates/mail/user/auth/activate.tmpl b/templates/mail/user/auth/activate.tmpl index b1bb4cb4631..9f3202d1af2 100644 --- a/templates/mail/user/auth/activate.tmpl +++ b/templates/mail/user/auth/activate.tmpl @@ -12,6 +12,6 @@

    {{.locale.Tr "mail.activate_account.text_2" .ActiveCodeLives}}

    {{$activate_url}}


    {{.locale.Tr "mail.link_not_working_do_paste"}}

    -

    © {{AppName}}

    + {{template "footer_gitea"}} diff --git a/templates/mail/user/auth/activate_email.tmpl b/templates/mail/user/auth/activate_email.tmpl index 3d32f80a4e5..e35b1c33653 100644 --- a/templates/mail/user/auth/activate_email.tmpl +++ b/templates/mail/user/auth/activate_email.tmpl @@ -12,6 +12,6 @@

    {{.locale.Tr "mail.activate_email.text" .ActiveCodeLives}}

    {{$activate_url}}


    {{.locale.Tr "mail.link_not_working_do_paste"}}

    -

    © {{AppName}}

    + {{template "footer_gitea"}} diff --git a/templates/mail/user/auth/register_notify.tmpl b/templates/mail/user/auth/register_notify.tmpl index 62dbf7d9271..11effd66dce 100644 --- a/templates/mail/user/auth/register_notify.tmpl +++ b/templates/mail/user/auth/register_notify.tmpl @@ -13,6 +13,6 @@

    {{.locale.Tr "mail.register_notify.text_2" .Username}}

    {{AppUrl}}user/login


    {{.locale.Tr "mail.register_notify.text_3" $set_pwd_url}}


    -

    © {{AppName}}

    + {{template "footer_gitea"}} diff --git a/templates/mail/user/auth/reset_passwd.tmpl b/templates/mail/user/auth/reset_passwd.tmpl index 55b1ecec3f6..f9b47d7df83 100644 --- a/templates/mail/user/auth/reset_passwd.tmpl +++ b/templates/mail/user/auth/reset_passwd.tmpl @@ -12,6 +12,6 @@

    {{.locale.Tr "mail.reset_password.text" .ResetPwdCodeLives}}

    {{$recover_url}}


    {{.locale.Tr "mail.link_not_working_do_paste"}}

    -

    © {{AppName}}

    + {{template "footer_gitea"}}