mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 02:16:28 +00:00 
			
		
		
		
	Move git command to git/gitcmd (#35483)
The name cmd is already used in many places and may cause conflicts, so I chose `gitcmd` instead to minimize potential naming conflicts.
This commit is contained in:
		| @@ -27,6 +27,7 @@ import ( | ||||
| 	"code.gitea.io/gitea/models/webhook" | ||||
| 	"code.gitea.io/gitea/modules/commitstatus" | ||||
| 	"code.gitea.io/gitea/modules/git" | ||||
| 	"code.gitea.io/gitea/modules/git/gitcmd" | ||||
| 	"code.gitea.io/gitea/modules/gitrepo" | ||||
| 	"code.gitea.io/gitea/modules/queue" | ||||
| 	"code.gitea.io/gitea/modules/setting" | ||||
| @@ -294,12 +295,12 @@ func TestCantMergeUnrelated(t *testing.T) { | ||||
| 		}) | ||||
| 		path := repo_model.RepoPath(user1.Name, repo1.Name) | ||||
|  | ||||
| 		err := git.NewCommand("read-tree", "--empty").Run(t.Context(), &git.RunOpts{Dir: path}) | ||||
| 		err := gitcmd.NewCommand("read-tree", "--empty").Run(t.Context(), &gitcmd.RunOpts{Dir: path}) | ||||
| 		assert.NoError(t, err) | ||||
|  | ||||
| 		stdin := strings.NewReader("Unrelated File") | ||||
| 		var stdout strings.Builder | ||||
| 		err = git.NewCommand("hash-object", "-w", "--stdin").Run(t.Context(), &git.RunOpts{ | ||||
| 		err = gitcmd.NewCommand("hash-object", "-w", "--stdin").Run(t.Context(), &gitcmd.RunOpts{ | ||||
| 			Dir:    path, | ||||
| 			Stdin:  stdin, | ||||
| 			Stdout: &stdout, | ||||
| @@ -308,10 +309,10 @@ func TestCantMergeUnrelated(t *testing.T) { | ||||
| 		assert.NoError(t, err) | ||||
| 		sha := strings.TrimSpace(stdout.String()) | ||||
|  | ||||
| 		_, _, err = git.NewCommand("update-index", "--add", "--replace", "--cacheinfo").AddDynamicArguments("100644", sha, "somewher-over-the-rainbow").RunStdString(t.Context(), &git.RunOpts{Dir: path}) | ||||
| 		_, _, err = gitcmd.NewCommand("update-index", "--add", "--replace", "--cacheinfo").AddDynamicArguments("100644", sha, "somewher-over-the-rainbow").RunStdString(t.Context(), &gitcmd.RunOpts{Dir: path}) | ||||
| 		assert.NoError(t, err) | ||||
|  | ||||
| 		treeSha, _, err := git.NewCommand("write-tree").RunStdString(t.Context(), &git.RunOpts{Dir: path}) | ||||
| 		treeSha, _, err := gitcmd.NewCommand("write-tree").RunStdString(t.Context(), &gitcmd.RunOpts{Dir: path}) | ||||
| 		assert.NoError(t, err) | ||||
| 		treeSha = strings.TrimSpace(treeSha) | ||||
|  | ||||
| @@ -331,8 +332,8 @@ func TestCantMergeUnrelated(t *testing.T) { | ||||
| 		_, _ = messageBytes.WriteString("\n") | ||||
|  | ||||
| 		stdout.Reset() | ||||
| 		err = git.NewCommand("commit-tree").AddDynamicArguments(treeSha). | ||||
| 			Run(t.Context(), &git.RunOpts{ | ||||
| 		err = gitcmd.NewCommand("commit-tree").AddDynamicArguments(treeSha). | ||||
| 			Run(t.Context(), &gitcmd.RunOpts{ | ||||
| 				Env:    env, | ||||
| 				Dir:    path, | ||||
| 				Stdin:  messageBytes, | ||||
| @@ -341,7 +342,7 @@ func TestCantMergeUnrelated(t *testing.T) { | ||||
| 		assert.NoError(t, err) | ||||
| 		commitSha := strings.TrimSpace(stdout.String()) | ||||
|  | ||||
| 		_, _, err = git.NewCommand("branch", "unrelated").AddDynamicArguments(commitSha).RunStdString(t.Context(), &git.RunOpts{Dir: path}) | ||||
| 		_, _, err = gitcmd.NewCommand("branch", "unrelated").AddDynamicArguments(commitSha).RunStdString(t.Context(), &gitcmd.RunOpts{Dir: path}) | ||||
| 		assert.NoError(t, err) | ||||
|  | ||||
| 		testEditFileToNewBranch(t, session, "user1", "repo1", "master", "conflict", "README.md", "Hello, World (Edited Once)\n") | ||||
| @@ -925,13 +926,13 @@ func TestPullAutoMergeAfterCommitStatusSucceedAndApprovalForAgitFlow(t *testing. | ||||
|  | ||||
| 		stderrBuf := &bytes.Buffer{} | ||||
|  | ||||
| 		err = git.NewCommand("push", "origin", "HEAD:refs/for/master", "-o"). | ||||
| 		err = gitcmd.NewCommand("push", "origin", "HEAD:refs/for/master", "-o"). | ||||
| 			AddDynamicArguments(`topic=test/head2`). | ||||
| 			AddArguments("-o"). | ||||
| 			AddDynamicArguments(`title="create a test pull request with agit"`). | ||||
| 			AddArguments("-o"). | ||||
| 			AddDynamicArguments(`description="This PR is a test pull request which created with agit"`). | ||||
| 			Run(t.Context(), &git.RunOpts{Dir: dstPath, Stderr: stderrBuf}) | ||||
| 			Run(t.Context(), &gitcmd.RunOpts{Dir: dstPath, Stderr: stderrBuf}) | ||||
| 		assert.NoError(t, err) | ||||
|  | ||||
| 		assert.Contains(t, stderrBuf.String(), setting.AppURL+"user2/repo1/pulls/6") | ||||
|   | ||||
		Reference in New Issue
	
	Block a user