github/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-10-31 05:24:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Discard unread data of git cat-file (#29297)

Browse Source 
Fixes #29101
Related #29298

Discard all read data to prevent misinterpreting existing data. Some
discard calls were missing in error cases.

---------

Co-authored-by: yp05327 <576951401@qq.com>
This commit is contained in:
KN4CK3R
2024-02-22 04:48:19 +01:00
committed by GitHub
parent c236e64aca
commit d6811baf88
10 changed files with 66 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/git/commit_info_nogogit.go
View File

@@ -151,6 +151,9 @@ func GetLastCommitForPaths(ctx context.Context, commit *Commit, treePath string,
return nil, err
}
if typ != "commit" {
if err := DiscardFull(batchReader, size+1); err != nil {
return nil, err
}
return nil, fmt.Errorf("unexpected type: %s for commit id: %s", typ, commitID)
}
c, err = CommitFromReader(commit.repo, MustIDFromString(commitID), io.LimitReader(batchReader, size))