gitea/models
Philip Peterson b0936f4f41
Do not mutate incoming options to RenderUserSearch and SearchUsers (#34544)
This PR changes the `opts` argument in `SearchUsers()` to be passed by
value instead of by pointer, as its mutations do not escape the function
scope and are not used elsewhere. This simplifies reasoning about the
function and avoids unnecessary pointer usage.

This insight emerged during an initial attempt to refactor
`RenderUserSearch()`, which currently intermixes multiple concerns.

Co-authored-by: Philip Peterson <philip-peterson@users.noreply.github.com>
2025-05-27 19:36:02 +00:00
..
actions Fix ephemeral runner deletion (#34447) 2025-05-20 15:42:31 +00:00
activities Fix remove org user failure on mssql (#34449) 2025-05-14 02:33:56 +08:00
admin Fix omitempty bug (#33663) 2025-02-20 12:39:21 -08:00
asymkey Cache GPG keys, emails and users when list commits (#34086) 2025-04-09 16:34:38 +00:00
auth Enforce two-factor auth (2FA: TOTP or WebAuthn) (#34187) 2025-04-28 15:31:59 -07:00
avatars Replace 10 more gt- classes with tw- (#29945) 2024-03-22 13:45:10 +00:00
db Enable addtional linters (#34085) 2025-04-01 10:14:01 +00:00
dbfs Enable testifylint rules (#34075) 2025-03-31 01:53:48 -04:00
fixtures Split GetLatestCommitStatus as two functions (#34535) 2025-05-26 19:00:22 +00:00
git Split GetLatestCommitStatus as two functions (#34535) 2025-05-26 19:00:22 +00:00
issues Add sort option recentclose for issues and pulls (#34525) 2025-05-26 16:37:38 +00:00
migrations Add migrations tests (#34456) 2025-05-15 16:28:31 +00:00
organization Fix remove org user failure on mssql (#34449) 2025-05-14 02:33:56 +08:00
packages Swift files can be passed either as file or as form value (#34068) 2025-04-18 20:09:56 +08:00
perm Enforce two-factor auth (2FA: TOTP or WebAuthn) (#34187) 2025-04-28 15:31:59 -07:00
project Enable addtional linters (#34085) 2025-04-01 10:14:01 +00:00
pull Automerge supports deleting branch automatically after merging (#32343) 2025-01-10 03:51:03 +08:00
renderhelper Refactor commit message rendering and fix bugs (#34412) 2025-05-09 20:42:35 +08:00
repo Performance optimization for tags synchronization (#34355) 2025-05-22 13:54:42 -07:00
secret Added Description Field for Secrets and Variables (#33526) 2025-03-17 19:24:54 +00:00
shared/types Refactor locale&string&template related code (#29165) 2024-02-14 21:48:45 +00:00
system Enable testifylint rules (#34075) 2025-03-31 01:53:48 -04:00
unit Fix team permission (#34128) 2025-04-08 04:15:15 +00:00
unittest Uniform all temporary directories and allow customizing temp path (#32352) 2025-04-08 16:15:28 +00:00
user Do not mutate incoming options to RenderUserSearch and SearchUsers (#34544) 2025-05-27 19:36:02 +00:00
webhook fix webhook url (#34186) 2025-04-13 02:24:32 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
repo_test.go Enable testifylint rules (#34075) 2025-03-31 01:53:48 -04:00
repo.go Fix issue comment number (#30556) 2024-12-30 14:35:46 -08:00