settings: use enums for ChatTheme/FontSize, translate choices (#2667)

Also change SuggestionMode to work the same way.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Co-authored-by: Jared Van Bortel <jared@nomic.ai>

gpt4all-chat/qml/ApplicationSettings.qml

@@ -107,11 +107,12 @@ MySettingsTab {
             Layout.maximumWidth: 200
             Layout.fillWidth: false
             Layout.alignment: Qt.AlignRight
-            model: [qsTr("Dark"), qsTr("Light"), qsTr("LegacyDark")]
+            // NOTE: indices match values of ChatTheme enum, keep them in sync
+            model: [qsTr("Light"), qsTr("Dark"), qsTr("LegacyDark")]
             Accessible.name: themeLabel.text
             Accessible.description: themeLabel.helpText
             function updateModel() {
-                themeBox.currentIndex = themeBox.indexOfValue(MySettings.chatTheme);
+                themeBox.currentIndex = MySettings.chatTheme;
             }
             Component.onCompleted: {
                 themeBox.updateModel()
@@ -123,7 +124,7 @@ MySettingsTab {
                 }
             }
             onActivated: {
-                MySettings.chatTheme = themeBox.currentText
+                MySettings.chatTheme = themeBox.currentIndex
             }
         }
         MySettingsLabel {
@@ -141,11 +142,12 @@ MySettingsTab {
             Layout.maximumWidth: 200
             Layout.fillWidth: false
             Layout.alignment: Qt.AlignRight
-            model: ["Small", "Medium", "Large"]
+            // NOTE: indices match values of FontSize enum, keep them in sync
+            model: [qsTr("Small"), qsTr("Medium"), qsTr("Large")]
             Accessible.name: fontLabel.text
             Accessible.description: fontLabel.helpText
             function updateModel() {
-                fontBox.currentIndex = fontBox.indexOfValue(MySettings.fontSize);
+                fontBox.currentIndex = MySettings.fontSize;
             }
             Component.onCompleted: {
                 fontBox.updateModel()
@@ -157,7 +159,7 @@ MySettingsTab {
                 }
             }
             onActivated: {
-                MySettings.fontSize = fontBox.currentText
+                MySettings.fontSize = fontBox.currentIndex
             }
         }
         MySettingsLabel {
@@ -271,6 +273,7 @@ MySettingsTab {
             Layout.minimumWidth: 400
             Layout.maximumWidth: 400
             Layout.alignment: Qt.AlignRight
+            // NOTE: indices match values of SuggestionMode enum, keep them in sync
             model: [ qsTr("When chatting with LocalDocs"), qsTr("Whenever possible"), qsTr("Never") ]
             Accessible.name: suggestionModeLabel.text
             Accessible.description: suggestionModeLabel.helpText

gpt4all-chat/qml/MyButton.qml

@@ -3,6 +3,7 @@ import QtQuick
 import QtQuick.Controls
 import QtQuick.Controls.Basic
 import mysettings
+import mysettingsenums
 
 Button {
     id: myButton
@@ -14,7 +15,7 @@ Button {
     property color backgroundColor: theme.buttonBackground
     property color backgroundColorHovered: theme.buttonBackgroundHovered
     property real  backgroundRadius: 10
-    property real  borderWidth: MySettings.chatTheme === "LegacyDark" ? 1 : 0
+    property real  borderWidth: MySettings.chatTheme === MySettingsEnums.ChatTheme.LegacyDark ? 1 : 0
     property color borderColor: theme.buttonBorder
     property real  fontPixelSize: theme.fontSizeLarge
     property bool  fontPixelBold: false