From 3cd68ba0a9a39d2e07b782254b9fd299db6e91d2 Mon Sep 17 00:00:00 2001
From: jiangweidong <1053570670@qq.com>
Date: Wed, 18 Dec 2024 16:48:39 +0800
Subject: [PATCH] perf: push account without increasing version.

---
 apps/accounts/automations/change_secret/manager.py | 5 +++--
 apps/accounts/automations/push_account/manager.py  | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/apps/accounts/automations/change_secret/manager.py b/apps/accounts/automations/change_secret/manager.py
index 4d462dd6e..ab04b348c 100644
--- a/apps/accounts/automations/change_secret/manager.py
+++ b/apps/accounts/automations/change_secret/manager.py
@@ -161,7 +161,7 @@ class ChangeSecretManager(AccountBasePlaybookManager):
         return inventory_hosts
 
     @staticmethod
-    def need_change_account_version(account, recorder):
+    def require_update_version(account, recorder):
         return account.secret != recorder.new_secret
 
     def on_host_success(self, host, result):
@@ -176,6 +176,7 @@ class ChangeSecretManager(AccountBasePlaybookManager):
             print("Account not found, deleted ?")
             return
 
+        version_update_required = self.require_update_version(account, recorder)
         account.secret = recorder.new_secret
         account.date_updated = timezone.now()
 
@@ -186,7 +187,7 @@ class ChangeSecretManager(AccountBasePlaybookManager):
             try:
                 recorder.save()
                 account_update_fields = ['secret', 'date_updated']
-                if self.need_change_account_version(account, recorder):
+                if version_update_required:
                     account_update_fields.append('version')
                 account.save(update_fields=account_update_fields)
                 break
diff --git a/apps/accounts/automations/push_account/manager.py b/apps/accounts/automations/push_account/manager.py
index 0dd3898f7..e5a6db375 100644
--- a/apps/accounts/automations/push_account/manager.py
+++ b/apps/accounts/automations/push_account/manager.py
@@ -9,7 +9,7 @@ logger = get_logger(__name__)
 class PushAccountManager(ChangeSecretManager, AccountBasePlaybookManager):
 
     @staticmethod
-    def need_change_account_version(account, recorder):
+    def require_update_version(account, recorder):
         account.skip_history_when_saving = True
         return False