perf: applet host tips

This commit is contained in:
ibuler
2024-09-03 18:16:50 +08:00
committed by 老广
parent 7973239424
commit cf1dc79c68
4 changed files with 24 additions and 12 deletions

View File

@@ -9,9 +9,9 @@ from rest_framework.decorators import action
from rest_framework.request import Request
from rest_framework.response import Response
from common.api.mixin import CommonApiMixin
from common.const.http import GET
from common.drf.filters import BaseFilterSet
from common.api.mixin import CommonApiMixin
from terminal import const
from terminal.filters import CommandStorageFilter, CommandFilter, CommandFilterForStorageTree
from terminal.models import CommandStorage, ReplayStorage
@@ -30,8 +30,10 @@ class BaseStorageViewSetMixin(CommonApiMixin):
if instance.type_null_or_server or instance.is_default:
data = {'msg': _('Deleting the default storage is not allowed')}
return Response(data=data, status=status.HTTP_400_BAD_REQUEST)
if instance.is_use():
data = {'msg': _('Cannot delete storage that is being used')}
used_by = instance.used_by()
if used_by:
names = ', '.join(list(used_by.values_list('name', flat=True)))
data = {'msg': _('Cannot delete storage that is being used: {}').format(names)}
return Response(data=data, status=status.HTTP_400_BAD_REQUEST)
return super().destroy(request, *args, **kwargs)