github/k8sgpt
1
0
Fork 0
mirror of https://github.com/k8sgpt-ai/k8sgpt.git synced 2025-09-17 23:59:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add --no-install for activate command (#536)

Browse Source 
to fix #534

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
This commit is contained in:
Peter Pan
2023-07-03 18:36:02 +08:00
committed by GitHub
parent 5a983c4a0a
commit 1f5462c80b
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/integration/activate.go
View File

@@ -21,6 +21,10 @@ import (
"github.com/spf13/viper" "github.com/spf13/viper"
) )
var (
skipInstall bool
)
// activateCmd represents the activate command // activateCmd represents the activate command
var activateCmd = &cobra.Command{ var activateCmd = &cobra.Command{
Use: "activate [integration]", Use: "activate [integration]",
@@ -39,7 +43,7 @@ var activateCmd = &cobra.Command{
integration := integration.NewIntegration() integration := integration.NewIntegration()
// Check if the integation exists // Check if the integation exists
err := integration.Activate(integrationName, namespace, activeFilters) err := integration.Activate(integrationName, namespace, activeFilters, skipInstall)
if err != nil { if err != nil {
color.Red("Error: %v", err) color.Red("Error: %v", err)
return return
@@ -51,5 +55,6 @@ var activateCmd = &cobra.Command{
func init() { func init() {
IntegrationCmd.AddCommand(activateCmd) IntegrationCmd.AddCommand(activateCmd)
activateCmd.Flags().BoolVarP(&skipInstall, "no-install", "s", false, "Only activate the integration filter without installing the filter (for example, if that filter plugin is already deployed in cluster, we do not need to re-install it again)")
} }

8
pkg/integration/integration.go
View File

@@ -66,7 +66,7 @@ func (*Integration) Get(name string) (IIntegration, error) {
return integrations[name], nil return integrations[name], nil
} }
func (*Integration) Activate(name string, namespace string, activeFilters []string) error { func (*Integration) Activate(name string, namespace string, activeFilters []string, skipInstall bool) error {
if _, ok := integrations[name]; !ok { if _, ok := integrations[name]; !ok {
return errors.New("integration not found") return errors.New("integration not found")
} }
@@ -83,8 +83,10 @@ func (*Integration) Activate(name string, namespace string, activeFilters []stri
viper.Set("active_filters", uniqueFilters) viper.Set("active_filters", uniqueFilters)
if err := integrations[name].Deploy(namespace); err != nil { if !skipInstall {
return err if err := integrations[name].Deploy(namespace); err != nil {
return err
}
} }
if err := viper.WriteConfig(); err != nil { if err := viper.WriteConfig(); err != nil {