github/k8sgpt
1
0
Fork 0
mirror of https://github.com/k8sgpt-ai/k8sgpt.git synced 2025-09-16 23:32:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove pointer to loop variable when searching the latest event to analyze (#328)

Browse Source 
Having a pointer to a range variable will always yield the latest value
the loop sees. This leads to subtle bugs. To prevent this from
happening, the range variable was assigned to a temp variable, which is
then referenced as a pointer.

Signed-off-by: Patrick Pichler <git@patrickpichler.dev>
Co-authored-by: Patrick Pichler <git@patrickpichler.dev>
This commit is contained in:
Patrick Pichler
2023-04-25 11:06:45 +02:00
committed by GitHub
parent 3d11e12963
commit 2616220935
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/serve/serve.go
View File

@@ -76,7 +76,11 @@ var ServeCmd = &cobra.Command{
if aiProvider == nil { if aiProvider == nil {
for _, provider := range configAI.Providers { for _, provider := range configAI.Providers {
if backend == provider.Name { if backend == provider.Name {
aiProvider = &provider // he pointer to the range variable is not really an issue here, as there
// is a break right after, but to prevent potential future issues, a temp
// variable is assigned
p := provider
aiProvider = &p
break break
} }
} }

8
pkg/analyzer/events.go
View File

@@ -36,10 +36,14 @@ func FetchLatestEvent(ctx context.Context, kubernetesClient *kubernetes.Client,
var latestEvent *v1.Event var latestEvent *v1.Event
for _, event := range events.Items { for _, event := range events.Items {
if latestEvent == nil { if latestEvent == nil {
latestEvent = &event // this is required, as a pointer to a loop variable would always yield the latest value in the range
e := event
latestEvent = &e
} }
if event.LastTimestamp.After(latestEvent.LastTimestamp.Time) { if event.LastTimestamp.After(latestEvent.LastTimestamp.Time) {
latestEvent = &event // this is required, as a pointer to a loop variable would always yield the latest value in the range
e := event
latestEvent = &e
} }
} }
return latestEvent, nil return latestEvent, nil