From 60a9794363f082c8697acac9075f1bb0dfdd0b09 Mon Sep 17 00:00:00 2001
From: Anas Khan <anxkhn28@gmail.com>
Date: Tue, 7 Jul 2026 17:06:48 +0530
Subject: [PATCH] fix: correct Vertex AI legacy model ids by removing stray
 asterisk (#1684)

The two Vertex AI "Legacy Stable Model" constants carried a trailing '*'
that leaked in from the footnote marker in Google's model-versions table:
ModelGeminiProV1_5 was "gemini-1.5-pro-002*" and ModelGeminiFlashV1_5 was
"gemini-1.5-flash-002*". The '*' is not part of the model id.

GetVertexAIModelOrDefault does an exact-match lookup and otherwise silently
returns VERTEXAI_MODELS[0]. Because VERTEXAI_MODELS held the asterisked
values, a user who correctly configured --model gemini-1.5-pro-002 failed
the exact match and was silently switched to the default model, so the two
legacy models could never be selected.

Remove the trailing '*' from both literals and add a unit test covering the
model and region resolvers.

Closes #1516

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
---
 pkg/ai/googlevertexai.go      |  4 +--
 pkg/ai/googlevertexai_test.go | 58 +++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+), 2 deletions(-)
 create mode 100644 pkg/ai/googlevertexai_test.go

diff --git a/pkg/ai/googlevertexai.go b/pkg/ai/googlevertexai.go
index 2a345296..f25d1546 100644
--- a/pkg/ai/googlevertexai.go
+++ b/pkg/ai/googlevertexai.go
@@ -66,8 +66,8 @@ const (
 	ModelGeminiFlashV2_5   = "gemini-2.5-flash"      // Latest Stable Model
 	ModelGeminiFlashV2     = "gemini-2.0-flash"      // Latest Stable Model
 	ModelGeminiFlashLiteV2 = "gemini-2.0-flash-lite" // Latest Stable Model
-	ModelGeminiProV1_5     = "gemini-1.5-pro-002*"   // Legacy Stable Model
-	ModelGeminiFlashV1_5   = "gemini-1.5-flash-002*" // Legacy Stable Model
+	ModelGeminiProV1_5     = "gemini-1.5-pro-002"    // Legacy Stable Model
+	ModelGeminiFlashV1_5   = "gemini-1.5-flash-002"  // Legacy Stable Model
 )
 
 var VERTEXAI_MODELS = []string{
diff --git a/pkg/ai/googlevertexai_test.go b/pkg/ai/googlevertexai_test.go
new file mode 100644
index 00000000..8bbca27d
--- /dev/null
+++ b/pkg/ai/googlevertexai_test.go
@@ -0,0 +1,58 @@
+/*
+Copyright 2023 The K8sGPT Authors.
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package ai
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetVertexAIModelOrDefault(t *testing.T) {
+	tests := []struct {
+		name  string
+		model string
+		want  string
+	}{
+		{"latest stable pro is preserved", ModelGeminiProV2_5, "gemini-2.5-pro"},
+		{"legacy stable pro is preserved", "gemini-1.5-pro-002", "gemini-1.5-pro-002"},
+		{"legacy stable flash is preserved", "gemini-1.5-flash-002", "gemini-1.5-flash-002"},
+		{"unknown model falls back to default", "does-not-exist", VERTEXAI_MODELS[0]},
+		{"empty model falls back to default", "", VERTEXAI_MODELS[0]},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, GetVertexAIModelOrDefault(tt.model))
+		})
+	}
+}
+
+func TestGetVertexAIRegionOrDefault(t *testing.T) {
+	tests := []struct {
+		name   string
+		region string
+		want   string
+	}{
+		{"supported region is preserved", US_West_4, "us-west4"},
+		{"unknown region falls back to default", "moon-base-1", VERTEXAI_DEFAULT_REGION},
+		{"empty region falls back to default", "", VERTEXAI_DEFAULT_REGION},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, GetVertexAIRegionOrDefault(tt.region))
+		})
+	}
+}