github/k8sgpt
1
0
Fork 0
mirror of https://github.com/k8sgpt-ai/k8sgpt.git synced 2025-08-18 15:57:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: analyze command default backend bug (#966)

Browse Source 
Now, the default value of the `backend` flag for the analyze command
will be an empty string. And the `NewAnalysis` function has been
modified to use the default backend set by the user if the backend flag
is not provided and the `defaultprovider` is set in the config file.
Otherwise, backend will be set to "openai".

Fixes: https://github.com/k8sgpt-ai/k8sgpt/issues/902

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
Co-authored-by: JuHyung Son <sonju0427@gmail.com>
This commit is contained in:
Vaibhav Malik 2024-02-28 21:39:30 +05:30 committed by GitHub
parent 334a86aaf4
commit aab8d77feb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/analyze/analyze.go
View File

@ -60,6 +60,7 @@ var AnalyzeCmd = &cobra.Command{
withDoc, withDoc,
interactiveMode, interactiveMode,
) )
if err != nil { if err != nil {
color.Red("Error: %v", err) color.Red("Error: %v", err)
os.Exit(1) os.Exit(1)
@ -124,7 +125,7 @@ func init() {
// explain flag // explain flag
AnalyzeCmd.Flags().BoolVarP(&explain, "explain", "e", false, "Explain the problem to me") AnalyzeCmd.Flags().BoolVarP(&explain, "explain", "e", false, "Explain the problem to me")
// add flag for backend // add flag for backend
AnalyzeCmd.Flags().StringVarP(&backend, "backend", "b", "openai", "Backend AI provider") AnalyzeCmd.Flags().StringVarP(&backend, "backend", "b", "", "Backend AI provider")
// output as json // output as json
AnalyzeCmd.Flags().StringVarP(&output, "output", "o", "text", "Output format (text, json)") AnalyzeCmd.Flags().StringVarP(&output, "output", "o", "text", "Output format (text, json)")
// add language options for output // add language options for output

8
pkg/analysis/analysis.go
View File

@ -124,11 +124,15 @@ func NewAnalysis(
} }
// Backend string will have high priority than a default provider // Backend string will have high priority than a default provider
// Backend as "openai" represents the default CLI argument passed through // Hence, use the default provider only if the backend is not specified by the user.
if configAI.DefaultProvider != "" && backend == "openai" { if configAI.DefaultProvider != "" && backend == "" {
backend = configAI.DefaultProvider backend = configAI.DefaultProvider
} }
if backend == "" {
backend = "openai"
}
var aiProvider ai.AIProvider var aiProvider ai.AIProvider
for _, provider := range configAI.Providers { for _, provider := range configAI.Providers {
if backend == provider.Name { if backend == provider.Name {

4
pkg/server/analyze.go
View File

@ -16,10 +16,6 @@ func (h *handler) Analyze(ctx context.Context, i *schemav1.AnalyzeRequest) (
i.Output = "json" i.Output = "json"
} }
if i.Backend == "" {
i.Backend = "openai"
}
if int(i.MaxConcurrency) == 0 { if int(i.MaxConcurrency) == 0 {
i.MaxConcurrency = 10 i.MaxConcurrency = 10
} }