diff --git a/pkg/analysis/analysis.go b/pkg/analysis/analysis.go index f420ca1..e8b2ed6 100644 --- a/pkg/analysis/analysis.go +++ b/pkg/analysis/analysis.go @@ -3,6 +3,7 @@ package analysis import ( "context" "encoding/json" + "errors" "fmt" "strings" @@ -73,6 +74,8 @@ func (a *Analysis) RunAnalysis() error { return err } a.Results = append(a.Results, results...) + } else { + return errors.New(fmt.Sprintf("\"%s\" filter does not exist. Please run k8sgpt filters list.", filter)) } } return nil diff --git a/pkg/analyzer/hpa.go b/pkg/analyzer/hpa.go index 983d999..fe16a76 100644 --- a/pkg/analyzer/hpa.go +++ b/pkg/analyzer/hpa.go @@ -2,7 +2,6 @@ package analyzer import ( "fmt" - "github.com/k8sgpt-ai/k8sgpt/pkg/common" "github.com/k8sgpt-ai/k8sgpt/pkg/util" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" @@ -28,22 +27,22 @@ func (HpaAnalyzer) Analyze(a common.Analyzer) ([]common.Result, error) { switch scaleTargetRef.Kind { case "Deployment": - _, err := a.Client.GetClient().AppsV1().Deployments(a.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) + _, err := a.Client.GetClient().AppsV1().Deployments(hpa.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) if err != nil { scaleTargetRefNotFound = true } case "ReplicationController": - _, err := a.Client.GetClient().CoreV1().ReplicationControllers(a.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) + _, err := a.Client.GetClient().CoreV1().ReplicationControllers(hpa.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) if err != nil { scaleTargetRefNotFound = true } case "ReplicaSet": - _, err := a.Client.GetClient().AppsV1().ReplicaSets(a.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) + _, err := a.Client.GetClient().AppsV1().ReplicaSets(hpa.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) if err != nil { scaleTargetRefNotFound = true } case "StatefulSet": - _, err := a.Client.GetClient().AppsV1().StatefulSets(a.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) + _, err := a.Client.GetClient().AppsV1().StatefulSets(hpa.Namespace).Get(a.Context, scaleTargetRef.Name, metav1.GetOptions{}) if err != nil { scaleTargetRefNotFound = true }