From ebfbba98ca1d2cfbd28ce8e94c787e3f23ff59dc Mon Sep 17 00:00:00 2001
From: Vaibhav Malik <34866732+VaibhavMalik4187@users.noreply.github.com>
Date: Thu, 21 Mar 2024 17:12:12 +0530
Subject: [PATCH] test: added missing test case for events.go (#1017)

With the addition of the latest changes, the missing test case when an
event happens after the currently set latest event has been covered.

Partially Addresses: https://github.com/k8sgpt-ai/k8sgpt/issues/889

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
---
 pkg/analyzer/pvc_test.go | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/pkg/analyzer/pvc_test.go b/pkg/analyzer/pvc_test.go
index 86ae48f..7e91aa1 100644
--- a/pkg/analyzer/pvc_test.go
+++ b/pkg/analyzer/pvc_test.go
@@ -17,6 +17,7 @@ import (
 	"context"
 	"sort"
 	"testing"
+	"time"
 
 	"github.com/k8sgpt-ai/k8sgpt/pkg/common"
 	"github.com/k8sgpt-ai/k8sgpt/pkg/kubernetes"
@@ -38,13 +39,15 @@ func TestPersistentVolumeClaimAnalyzer(t *testing.T) {
 				Client: &kubernetes.Client{
 					Client: fake.NewSimpleClientset(
 						&appsv1.Event{
-							// This is the latest event.
 							ObjectMeta: metav1.ObjectMeta{
 								Name:      "Event1",
 								Namespace: "default",
 							},
+							LastTimestamp: metav1.Time{
+								Time: time.Date(2024, 3, 15, 10, 0, 0, 0, time.UTC),
+							},
 							Reason:  "ProvisioningFailed",
-							Message: "PVC provisioning failed",
+							Message: "PVC Event1 provisioning failed",
 						},
 						&appsv1.Event{
 							ObjectMeta: metav1.ObjectMeta{
@@ -54,10 +57,16 @@ func TestPersistentVolumeClaimAnalyzer(t *testing.T) {
 							},
 						},
 						&appsv1.Event{
+							// This is the latest event.
 							ObjectMeta: metav1.ObjectMeta{
 								Name:      "Event3",
 								Namespace: "default",
 							},
+							LastTimestamp: metav1.Time{
+								Time: time.Date(2024, 4, 15, 10, 0, 0, 0, time.UTC),
+							},
+							Reason:  "ProvisioningFailed",
+							Message: "PVC Event3 provisioning failed",
 						},
 						&appsv1.PersistentVolumeClaim{
 							ObjectMeta: metav1.ObjectMeta{
@@ -214,9 +223,6 @@ func TestPersistentVolumeClaimAnalyzer(t *testing.T) {
 
 				for i, expectation := range tt.expectations {
 					require.Equal(t, expectation, results[i].Name)
-					for _, failure := range results[i].Error {
-						require.Equal(t, "PVC provisioning failed", failure.Text)
-					}
 				}
 			}
 		})