mirror of
https://github.com/k8sgpt-ai/k8sgpt.git
synced 2025-08-23 09:58:21 +00:00
8adde6bf87
Before, there was no failure reported by the netpol analyzer, if the matcher on the policy doesn't match any pods. Signed-off-by: Patrick Pichler <git@patrickpichler.dev>
97 lines
2.7 KiB
Go
97 lines
2.7 KiB
Go
/*
|
|
Copyright 2023 The K8sGPT Authors.
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package analyzer
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/k8sgpt-ai/k8sgpt/pkg/common"
|
|
"github.com/k8sgpt-ai/k8sgpt/pkg/util"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
)
|
|
|
|
type NetworkPolicyAnalyzer struct{}
|
|
|
|
func (NetworkPolicyAnalyzer) Analyze(a common.Analyzer) ([]common.Result, error) {
|
|
|
|
kind := "NetworkPolicy"
|
|
|
|
AnalyzerErrorsMetric.DeletePartialMatch(map[string]string{
|
|
"analyzer_name": kind,
|
|
})
|
|
|
|
// get all network policies in the namespace
|
|
policies, err := a.Client.GetClient().NetworkingV1().
|
|
NetworkPolicies(a.Namespace).List(a.Context, metav1.ListOptions{})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var preAnalysis = map[string]common.PreAnalysis{}
|
|
|
|
for _, policy := range policies.Items {
|
|
var failures []common.Failure
|
|
|
|
// Check if policy allows traffic to all pods in the namespace
|
|
if len(policy.Spec.PodSelector.MatchLabels) == 0 {
|
|
failures = append(failures, common.Failure{
|
|
Text: fmt.Sprintf("Network policy allows traffic to all pods: %s", policy.Name),
|
|
Sensitive: []common.Sensitive{
|
|
{
|
|
Unmasked: policy.Name,
|
|
Masked: util.MaskString(policy.Name),
|
|
},
|
|
},
|
|
})
|
|
} else {
|
|
// Check if policy is not applied to any pods
|
|
podList, err := util.GetPodListByLabels(a.Client.GetClient(), a.Namespace, policy.Spec.PodSelector.MatchLabels)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(podList.Items) == 0 {
|
|
failures = append(failures, common.Failure{
|
|
Text: fmt.Sprintf("Network policy is not applied to any pods: %s", policy.Name),
|
|
Sensitive: []common.Sensitive{
|
|
{
|
|
Unmasked: policy.Name,
|
|
Masked: util.MaskString(policy.Name),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
}
|
|
|
|
if len(failures) > 0 {
|
|
preAnalysis[fmt.Sprintf("%s/%s", policy.Namespace, policy.Name)] = common.PreAnalysis{
|
|
FailureDetails: failures,
|
|
NetworkPolicy: policy,
|
|
}
|
|
AnalyzerErrorsMetric.WithLabelValues(kind, policy.Name, policy.Namespace).Set(float64(len(failures)))
|
|
|
|
}
|
|
}
|
|
|
|
for key, value := range preAnalysis {
|
|
currentAnalysis := common.Result{
|
|
Kind: kind,
|
|
Name: key,
|
|
Error: value.FailureDetails,
|
|
}
|
|
a.Results = append(a.Results, currentAnalysis)
|
|
}
|
|
|
|
return a.Results, nil
|
|
}
|