mirror of
https://github.com/k8sgpt-ai/k8sgpt.git
synced 2026-07-17 02:04:40 +00:00
716c48aab9
The Gateway and GatewayClass analyzers indexed Status.Conditions[0] without a length check. A Gateway or GatewayClass with empty Status.Conditions (newly created, or no controller installed) panics the whole analyze run with 'index out of range [0] with length 0'. Guard both accesses with a length check, mirroring the existing PDB analyzer (pkg/analyzer/pdb.go). Add a unit test for each analyzer that exercises the empty-conditions path. Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com> Co-authored-by: Alex Jones <1235925+AlexsJones@users.noreply.github.com>
90 lines
2.6 KiB
Go
90 lines
2.6 KiB
Go
/*
|
|
Copyright 2023 The K8sGPT Authors.
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package analyzer
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/k8sgpt-ai/k8sgpt/pkg/common"
|
|
"github.com/k8sgpt-ai/k8sgpt/pkg/util"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
ctrl "sigs.k8s.io/controller-runtime/pkg/client"
|
|
gtwapi "sigs.k8s.io/gateway-api/apis/v1"
|
|
)
|
|
|
|
type GatewayClassAnalyzer struct{}
|
|
|
|
// Gateway analyser will analyse all different Kinds and search for missing object dependencies
|
|
func (GatewayClassAnalyzer) Analyze(a common.Analyzer) ([]common.Result, error) {
|
|
|
|
kind := "GatewayClass"
|
|
AnalyzerErrorsMetric.DeletePartialMatch(map[string]string{
|
|
"analyzer_name": kind,
|
|
})
|
|
|
|
gcList := >wapi.GatewayClassList{}
|
|
client := a.Client.CtrlClient
|
|
err := gtwapi.AddToScheme(client.Scheme())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
labelSelector := util.LabelStrToSelector(a.LabelSelector)
|
|
if err := client.List(a.Context, gcList, &ctrl.ListOptions{LabelSelector: labelSelector}); err != nil {
|
|
return nil, err
|
|
}
|
|
var preAnalysis = map[string]common.PreAnalysis{}
|
|
|
|
// Find all unhealthy gateway Classes
|
|
|
|
for _, gc := range gcList.Items {
|
|
var failures []common.Failure
|
|
|
|
gcName := gc.GetName()
|
|
// Check only the current condition
|
|
if len(gc.Status.Conditions) > 0 && gc.Status.Conditions[0].Status != metav1.ConditionTrue {
|
|
failures = append(failures, common.Failure{
|
|
Text: fmt.Sprintf(
|
|
"GatewayClass '%s' with a controller name '%s' is not accepted. Message: '%s'.",
|
|
gcName,
|
|
gc.Spec.ControllerName,
|
|
gc.Status.Conditions[0].Message,
|
|
),
|
|
Sensitive: []common.Sensitive{
|
|
{
|
|
Unmasked: gcName,
|
|
Masked: util.MaskString(gcName),
|
|
},
|
|
},
|
|
})
|
|
}
|
|
if len(failures) > 0 {
|
|
preAnalysis[gcName] = common.PreAnalysis{
|
|
GatewayClass: gc,
|
|
FailureDetails: failures,
|
|
}
|
|
AnalyzerErrorsMetric.WithLabelValues(kind, gcName, "").Set(float64(len(failures)))
|
|
}
|
|
}
|
|
for key, value := range preAnalysis {
|
|
var currentAnalysis = common.Result{
|
|
Kind: kind,
|
|
Name: key,
|
|
Error: value.FailureDetails,
|
|
}
|
|
a.Results = append(a.Results, currentAnalysis)
|
|
}
|
|
return a.Results, nil
|
|
}
|