mirror of
https://github.com/kata-containers/kata-containers.git
synced 2025-04-29 12:14:48 +00:00
action: Allow long lines if non-alphabetic
Overly long commit lines are annoying. But sometimes, we need to be able to force the use of long lines (for example to reference a URL). Ironically, I can't refer to the URL that explains this because of ... the long line check! Hence: ```sh $ cat <<EOT | tr -d '\n'; echo See: https://github.com/kata-containers/tests/tree/master/ cmd/checkcommits#handling-long-lines EOT ``` Maximum body length updated to 150 bytes for parity with: https://github.com/kata-containers/tests/pull/2848 Fixes: #687. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This commit is contained in:
parent
ce9a4eeffd
commit
0351732778
20
.github/workflows/commit-message-check.yaml
vendored
20
.github/workflows/commit-message-check.yaml
vendored
@ -48,7 +48,25 @@ jobs:
|
||||
uses: tim-actions/commit-message-checker-with-regex@v0.3.1
|
||||
with:
|
||||
commits: ${{ steps.get-pr-commits.outputs.commits }}
|
||||
pattern: '^.+(\n.{0,72})*$|^.+\n\s*[^a-zA-Z\s\n]|^.+\n\S+$'
|
||||
# Notes:
|
||||
#
|
||||
# - The subject line is not enforced here (see other check), but has
|
||||
# to be specified at the start of the regex as the action is passed
|
||||
# the entire commit message.
|
||||
#
|
||||
# - Body lines *can* be longer than the maximum if they start
|
||||
# with a non-alphabetic character.
|
||||
#
|
||||
# This allows stack traces, log files snippets, emails, long URLs,
|
||||
# etc to be specified. Some of these naturally "work" as they start
|
||||
# with numeric timestamps or addresses. Emails can but quoted using
|
||||
# the normal ">" character, markdown bullets ("-", "*") are also
|
||||
# useful for lists of URLs, but it is always possible to override
|
||||
# the check by simply space indenting the content you need to add.
|
||||
#
|
||||
# - A SoB comment can be any length (as it is unreasonable to penalise
|
||||
# people with long names/email addresses :)
|
||||
pattern: '^.+(\n([a-zA-Z].{0,149}|[^a-zA-Z\n].*|Signed-off-by:.*|))+$'
|
||||
error: 'Body line too long (max 72)'
|
||||
post_error: ${{ env.error_msg }}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user