From 048178bc5e5701d91b091f094b2b8991d89f4084 Mon Sep 17 00:00:00 2001 From: Ruoqing He Date: Mon, 26 May 2025 03:56:03 +0000 Subject: [PATCH] agent: Fix clippy `unnecessary_get_then_check` Manually fix `unnecessary_get_then_check` clippy warning as suggested by rust 1.85.1. ```console warning: unnecessary use of `get(&shared_mount.src_ctr).is_none()` --> src/sandbox.rs:431:25 | 431 | if src_ctrs.get(&shared_mount.src_ctr).is_none() { | ---------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!src_ctrs.contains_key(&shared_mount.src_ctr)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check ``` Signed-off-by: Ruoqing He --- src/agent/src/sandbox.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agent/src/sandbox.rs b/src/agent/src/sandbox.rs index 307513fdf3..b8ba9e45ef 100644 --- a/src/agent/src/sandbox.rs +++ b/src/agent/src/sandbox.rs @@ -428,7 +428,7 @@ impl Sandbox { pub fn setup_shared_mounts(&self, c: &LinuxContainer, mounts: &Vec) -> Result<()> { let mut src_ctrs: HashMap = HashMap::new(); for shared_mount in mounts { - if src_ctrs.get(&shared_mount.src_ctr).is_none() { + if !src_ctrs.contains_key(&shared_mount.src_ctr) { if let Some(c) = self.find_container_by_name(&shared_mount.src_ctr) { src_ctrs.insert(shared_mount.src_ctr.clone(), c.init_process_pid); }