From 09b0b4c11d9eed53dc5c433ab17ba75bd06d6af9 Mon Sep 17 00:00:00 2001
From: Archana Choudhary <archana1@microsoft.com>
Date: Sun, 21 Apr 2024 12:02:28 +0000
Subject: [PATCH] genpolicy: add default implementation for get_sandbox_name

- Provide default implementation for get_sandbox_name in K8sResource trait
- Remove default implementation from structs implementing the trait K8sResource

Fixes: #8960
Signed-off-by: Archana Choudhary <archana1@microsoft.com>
---
 src/tools/genpolicy/src/config_map.rs | 4 ----
 src/tools/genpolicy/src/list.rs       | 4 ----
 src/tools/genpolicy/src/no_policy.rs  | 4 ----
 src/tools/genpolicy/src/secret.rs     | 4 ----
 src/tools/genpolicy/src/yaml.rs       | 5 ++++-
 5 files changed, 4 insertions(+), 17 deletions(-)

diff --git a/src/tools/genpolicy/src/config_map.rs b/src/tools/genpolicy/src/config_map.rs
index da6290f3e7..479fbc5c56 100644
--- a/src/tools/genpolicy/src/config_map.rs
+++ b/src/tools/genpolicy/src/config_map.rs
@@ -89,10 +89,6 @@ impl yaml::K8sResource for ConfigMap {
         self.doc_mapping = doc_mapping.clone();
     }
 
-    fn get_sandbox_name(&self) -> Option<String> {
-        panic!("Unsupported");
-    }
-
     fn get_container_mounts_and_storages(
         &self,
         _policy_mounts: &mut Vec<policy::KataMount>,
diff --git a/src/tools/genpolicy/src/list.rs b/src/tools/genpolicy/src/list.rs
index 9e4a48836e..4a0daf28f6 100644
--- a/src/tools/genpolicy/src/list.rs
+++ b/src/tools/genpolicy/src/list.rs
@@ -49,10 +49,6 @@ impl yaml::K8sResource for List {
         }
     }
 
-    fn get_sandbox_name(&self) -> Option<String> {
-        panic!("Unsupported");
-    }
-
     fn get_container_mounts_and_storages(
         &self,
         _policy_mounts: &mut Vec<policy::KataMount>,
diff --git a/src/tools/genpolicy/src/no_policy.rs b/src/tools/genpolicy/src/no_policy.rs
index b920550999..0b7e2b75c7 100644
--- a/src/tools/genpolicy/src/no_policy.rs
+++ b/src/tools/genpolicy/src/no_policy.rs
@@ -30,10 +30,6 @@ impl yaml::K8sResource for NoPolicyResource {
     ) {
     }
 
-    fn get_sandbox_name(&self) -> Option<String> {
-        panic!("Unsupported");
-    }
-
     fn get_container_mounts_and_storages(
         &self,
         _policy_mounts: &mut Vec<policy::KataMount>,
diff --git a/src/tools/genpolicy/src/secret.rs b/src/tools/genpolicy/src/secret.rs
index 6def0cf49c..ac497510af 100644
--- a/src/tools/genpolicy/src/secret.rs
+++ b/src/tools/genpolicy/src/secret.rs
@@ -78,10 +78,6 @@ impl yaml::K8sResource for Secret {
         self.doc_mapping = doc_mapping.clone();
     }
 
-    fn get_sandbox_name(&self) -> Option<String> {
-        panic!("Unsupported");
-    }
-
     fn get_container_mounts_and_storages(
         &self,
         _policy_mounts: &mut Vec<policy::KataMount>,
diff --git a/src/tools/genpolicy/src/yaml.rs b/src/tools/genpolicy/src/yaml.rs
index 71f4f93195..17b9394354 100644
--- a/src/tools/genpolicy/src/yaml.rs
+++ b/src/tools/genpolicy/src/yaml.rs
@@ -52,7 +52,10 @@ pub trait K8sResource {
     fn generate_policy(&self, agent_policy: &policy::AgentPolicy) -> String;
     fn serialize(&mut self, policy: &str) -> String;
 
-    fn get_sandbox_name(&self) -> Option<String>;
+    fn get_sandbox_name(&self) -> Option<String> {
+        panic!("Unsupported");
+    }
+
     fn get_namespace(&self) -> Option<String> {
         panic!("Unsupported");
     }