From 102a9dda71741e6c0bff4b7864a2f95ecb5919ee Mon Sep 17 00:00:00 2001
From: Peng Tao <bergwolf@hyper.sh>
Date: Sun, 9 Oct 2022 11:48:06 +0800
Subject: [PATCH] workflow: Revert "workflow: trigger test-kata-deploy with
 pull_request"

This reverts commit 7676cde0c5c4e5a99bca626770e534cab48c1db7.
It turns out that when triggerred from a PR, the docker login command is
failing with
```
Error: Cannot perform an interactive login from a non TTY device
```

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
---
 .github/workflows/kata-deploy-test.yaml | 27 ++++++-------------------
 docs/Release-Process.md                 |  2 +-
 2 files changed, 7 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/kata-deploy-test.yaml b/.github/workflows/kata-deploy-test.yaml
index e7ff49e1a5..c2270ebd05 100644
--- a/.github/workflows/kata-deploy-test.yaml
+++ b/.github/workflows/kata-deploy-test.yaml
@@ -1,19 +1,11 @@
 on:
-  pull_request: # this will trigger the workflow on PRs that changes release version
-    types:
-      - opened
-      - edited
-      - reopened
-      - synchronize
-    paths:
-      - VERSION
-  workflow_dispatch: # this allows to trigger the workflow manually on non-main branches
+  workflow_dispatch: # this is used to trigger the workflow on non-main branches
     inputs:
       pr:
         description: 'PR number from the selected branch to test'
         type: string
         required: true
-  issue_comment: # this allows to trigger the workflow from main by commenting "/test_kata_deploy"
+  issue_comment:
     types: [created, edited]
 
 name: test-kata-deploy
@@ -27,14 +19,13 @@ jobs:
       && github.event.action == 'created'
       && startsWith(github.event.comment.body, '/test_kata_deploy')
       || github.event_name == 'workflow_dispatch'
-      || github.event_name == 'pull_request'
     steps:
       - name: Check membership on comment or dispatch
         uses: kata-containers/is-organization-member@1.0.1
         id: is_organization_member
         with:
           organization: kata-containers
-          username: ${{ github.event.comment.user.login || github.event.sender.login }} # first one applies only on issue_comment
+          username: ${{ github.event.comment.user.login || github.event.sender.login }}
           token: ${{ secrets.GITHUB_TOKEN }}
       - name: Fail if not member
         run: |
@@ -70,10 +61,8 @@ jobs:
         run: |
             if [ ${{ github.event_name }} == 'issue_comment' ]; then
                 ref=$(cat $GITHUB_EVENT_PATH | jq -r '.issue.pull_request.url' | sed  's#^.*\/pulls#refs\/pull#' | sed 's#$#\/merge#')
-            elif [ ${{ github.event_name }} == 'workflow_dispatch' ]; then
+            else # workflow_dispatch
                 ref="refs/pull/${{ github.event.inputs.pr }}/merge"
-            elif [ ${{ github.event_name }} == 'pull_request' ]; then
-                ref="refs/pull/${{ github.event.number }}/merge"
             fi
             echo "reference for PR: " ${ref} "event:" ${{ github.event_name }}
             echo "##[set-output name=pr-ref;]${ref}"
@@ -112,10 +101,8 @@ jobs:
         run: |
             if [ ${{ github.event_name }} == 'issue_comment' ]; then
                 ref=$(cat $GITHUB_EVENT_PATH | jq -r '.issue.pull_request.url' | sed  's#^.*\/pulls#refs\/pull#' | sed 's#$#\/merge#')
-            elif [ ${{ github.event_name }} == 'workflow_dispatch' ]; then
+            else # workflow_dispatch
                 ref="refs/pull/${{ github.event.inputs.pr }}/merge"
-            elif [ ${{ github.event_name }} == 'pull_request' ]; then
-                ref="refs/pull/${{ github.event.number }}/merge"
             fi
             echo "reference for PR: " ${ref} "event:" ${{ github.event_name }}
             echo "##[set-output name=pr-ref;]${ref}"
@@ -145,10 +132,8 @@ jobs:
         run: |
             if [ ${{ github.event_name }} == 'issue_comment' ]; then
                 ref=$(cat $GITHUB_EVENT_PATH | jq -r '.issue.pull_request.url' | sed  's#^.*\/pulls#refs\/pull#' | sed 's#$#\/merge#')
-            elif [ ${{ github.event_name }} == 'workflow_dispatch' ]; then
+            else # workflow_dispatch
                 ref="refs/pull/${{ github.event.inputs.pr }}/merge"
-            elif [ ${{ github.event_name }} == 'pull_request' ]; then
-                ref="refs/pull/${{ github.event.number }}/merge"
             fi
             echo "reference for PR: " ${ref} "event:" ${{ github.event_name }}
             echo "##[set-output name=pr-ref;]${ref}"
diff --git a/docs/Release-Process.md b/docs/Release-Process.md
index c9991d4b09..7dcfb84a30 100644
--- a/docs/Release-Process.md
+++ b/docs/Release-Process.md
@@ -48,7 +48,7 @@
 ### Merge all bump version Pull requests
 
   - The above step will create a GitHub pull request in the Kata projects. Trigger the CI using `/test` command on each bump Pull request.
-  - `test-kata-deploy` workflow should be triggered automatically, validate it passes under the `Actions` tab on the repository GitHub page (you're also able to run it manually from there).
+  - Trigger the `test-kata-deploy` workflow which is under the `Actions` tab on the repository GitHub page (make sure to select the correct branch and validate it passes).
   - Check any failures and fix if needed.
   - Work with the Kata approvers to verify that the CI works and the pull requests are merged.