From 142342012c01debcd8b4c8812e6cc2b62daf698e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Wed, 8 May 2024 18:40:22 +0200 Subject: [PATCH] tests: pull-image: Don't run on TEEs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Let's skip those tests on TEEs as we've been facing a reasonable amount of issues, most likely on the containerd side, related to pulling the image on the guest. Once we're able to fix the issues on containerd, we can get back and re-enable those by reverting this commit. The decision of disabling the tests for TEEs is because the machines may end up in a state where human intervention is necessary to get them back to a functional state, and that's really not optimal for our CI. Signed-off-by: Fabiano Fidêncio --- tests/integration/kubernetes/k8s-guest-pull-image.bats | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/integration/kubernetes/k8s-guest-pull-image.bats b/tests/integration/kubernetes/k8s-guest-pull-image.bats index 4a9a133ad6..93d9120a68 100644 --- a/tests/integration/kubernetes/k8s-guest-pull-image.bats +++ b/tests/integration/kubernetes/k8s-guest-pull-image.bats @@ -9,7 +9,8 @@ load "${BATS_TEST_DIRNAME}/lib.sh" load "${BATS_TEST_DIRNAME}/confidential_common.sh" setup() { - confidential_setup || skip "Test not supported for ${KATA_HYPERVISOR}." + confidential_setup && skip "Due to issues related to pull-image integration skip tests for ${KATA_HYPERVISOR}." + [ "${SNAPSHOTTER:-}" = "nydus" ] || skip "None snapshotter was found but this test requires one" setup_common @@ -19,6 +20,8 @@ setup() { } @test "Test we can pull an unencrypted image outside the guest with runc and then inside the guest successfully" { + confidential_setup && skip "Due to issues related to pull-image integration skip tests for ${KATA_HYPERVISOR}." + # 1. Create one runc pod with the $unencrypted_image_1 image # We want to have one runc pod, so we pass a fake runtimeclass "runc" and then delete the runtimeClassName, # because the runtimeclass is not optional in new_pod_config function. @@ -213,7 +216,8 @@ setup() { } teardown() { - check_hypervisor_for_confidential_tests ${KATA_HYPERVISOR} || skip "Test not supported for ${KATA_HYPERVISOR}." + confidential_setup && skip "Due to issues related to pull-image integration skip tests for ${KATA_HYPERVISOR}." + [ "${SNAPSHOTTER:-}" = "nydus" ] || skip "None snapshotter was found but this test requires one" kubectl describe pod "$pod_name"