From 50fff977533bf8f3bf141313011bde434e4faa1a Mon Sep 17 00:00:00 2001 From: Eric Ernst Date: Thu, 1 Apr 2021 08:54:38 -0700 Subject: [PATCH 1/2] trace: move trace span chatter to trace rather than info No human should ever read that ouptut. Let's at least move it to trace for now. Fixes: #1615 Signed-off-by: Eric Ernst --- src/runtime/pkg/katautils/tracing.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/pkg/katautils/tracing.go b/src/runtime/pkg/katautils/tracing.go index 194ec2ed3f..0166ef1bc5 100644 --- a/src/runtime/pkg/katautils/tracing.go +++ b/src/runtime/pkg/katautils/tracing.go @@ -30,7 +30,7 @@ var _ export.SpanExporter = (*kataSpanExporter)(nil) // ExportSpans exports SpanData to Jaeger. func (e *kataSpanExporter) ExportSpans(ctx context.Context, spans []*export.SpanData) error { for _, span := range spans { - kataUtilsLogger.Infof("Reporting span %+v", span) + kataUtilsLogger.Tracef("Reporting span %+v", span) } return nil } From a4c125a8b9963ec1e5bd5b49a6ec72ca68b68d87 Mon Sep 17 00:00:00 2001 From: Eric Ernst Date: Thu, 1 Apr 2021 08:55:55 -0700 Subject: [PATCH 2/2] trace: move gRPC requests from debug to trace There are many requests to the agent that happen with relatively high frequency when a workload is running (checkRequest, as an example). Let's move from Debug to Trace to avoid bombarding journal. Signed-off-by: Eric Ernst --- src/runtime/virtcontainers/kata_agent.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/virtcontainers/kata_agent.go b/src/runtime/virtcontainers/kata_agent.go index a288288ee0..841b5989ca 100644 --- a/src/runtime/virtcontainers/kata_agent.go +++ b/src/runtime/virtcontainers/kata_agent.go @@ -2010,7 +2010,7 @@ func (k *kataAgent) sendReq(spanCtx context.Context, request interface{}) (inter if cancel != nil { defer cancel() } - k.Logger().WithField("name", msgName).WithField("req", message.String()).Debug("sending request") + k.Logger().WithField("name", msgName).WithField("req", message.String()).Trace("sending request") defer func() { agentRPCDurationsHistogram.WithLabelValues(msgName).Observe(float64(time.Since(start).Nanoseconds() / int64(time.Millisecond)))