From 15d511af97a0c0667ca6386933608ce9a28035e5 Mon Sep 17 00:00:00 2001 From: cncal Date: Tue, 7 May 2024 14:27:55 +0800 Subject: [PATCH] qemu: the error is logged only when it occurs Everytime I create contianer on arm64 machine, containerd/kata logs a redundant warning as follows: ``` shell time="2024-05-07" level=warning msg="" arch=arm64 name=containerd-shim-v2 pid=xxx sandbox=fdd1f05 source=virtcontainers/hypervisor ``` I added an error statement so that the error would be logged when it occurs. Signed-off-by: cncal --- src/runtime/virtcontainers/qemu_arm64.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/runtime/virtcontainers/qemu_arm64.go b/src/runtime/virtcontainers/qemu_arm64.go index 9e05c5452c..a9b803f732 100644 --- a/src/runtime/virtcontainers/qemu_arm64.go +++ b/src/runtime/virtcontainers/qemu_arm64.go @@ -156,6 +156,8 @@ func (q *qemuArm64) enableProtection() error { func (q *qemuArm64) appendProtectionDevice(devices []govmmQemu.Device, firmware, firmwareVolume string) ([]govmmQemu.Device, string, error) { err := q.enableProtection() - hvLogger.WithField("arch", runtime.GOARCH).Warnf("%v", err) + if err != nil { + hvLogger.WithField("arch", runtime.GOARCH).Error(err) + } return devices, firmware, err }