From 1625a5ce484d1c4eb8a20698d40636ee2976ee0e Mon Sep 17 00:00:00 2001 From: "James O. D. Hunt" Date: Mon, 6 Nov 2023 12:37:43 +0000 Subject: [PATCH] utils: kata-manager: Improve version check Update `github_get_latest_release()` to use `sort -V` rather than sub-sorting on the major, minor and patch level version number elements. The new approach is safer and more accurate. Signed-off-by: James O. D. Hunt --- utils/kata-manager.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/kata-manager.sh b/utils/kata-manager.sh index a70df88f18..34e596aa02 100755 --- a/utils/kata-manager.sh +++ b/utils/kata-manager.sh @@ -109,7 +109,7 @@ github_get_latest_release() local latest latest=$(curl -sL "$url" |\ jq -r '.[].tag_name | select(contains("-") | not)' |\ - sort -t "." -k1,1n -k2,2n -k3,3n |\ + sort -t '.' -V |\ tail -1 || true) [ -z "$latest" ] && die "Cannot determine latest release from $url"