From 19458ec47363c116c13aafd669c636d2bcb35471 Mon Sep 17 00:00:00 2001
From: Alice Frosi <afrosi@de.ibm.com>
Date: Tue, 2 Apr 2019 13:14:05 +0200
Subject: [PATCH] s390x: fix golangci-lint

Fix lint complains in the s390x files

Fixes: #1453

Signed-off-by: Alice Frosi <afrosi@de.ibm.com>
---
 cli/kata-check_s390x_test.go | 14 +++++++-------
 virtcontainers/qemu_s390x.go |  4 +---
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/cli/kata-check_s390x_test.go b/cli/kata-check_s390x_test.go
index d04b44a650..c8bc129ea4 100644
--- a/cli/kata-check_s390x_test.go
+++ b/cli/kata-check_s390x_test.go
@@ -123,50 +123,50 @@ func TestArchKernelParamHandler(t *testing.T) {
 
 	type testData struct {
 		onVMM        bool
+		expectIgnore bool
 		fields       logrus.Fields
 		msg          string
-		expectIgnore bool
 	}
 
 	data := []testData{
-		{true, logrus.Fields{}, "", false},
-		{false, logrus.Fields{}, "", false},
+		{true, false, logrus.Fields{}, ""},
+		{false, false, logrus.Fields{}, ""},
 
 		{
+			false,
 			false,
 			logrus.Fields{
 				// wrong type
 				"parameter": 123,
 			},
 			"foo",
-			false,
 		},
 
 		{
+			false,
 			false,
 			logrus.Fields{
 				"parameter": "unrestricted_guest",
 			},
 			"",
-			false,
 		},
 
 		{
+			true,
 			true,
 			logrus.Fields{
 				"parameter": "unrestricted_guest",
 			},
 			"",
-			true,
 		},
 
 		{
 			false,
+			true,
 			logrus.Fields{
 				"parameter": "nested",
 			},
 			"",
-			true,
 		},
 	}
 
diff --git a/virtcontainers/qemu_s390x.go b/virtcontainers/qemu_s390x.go
index 4815ea8a8a..a9c9970b81 100644
--- a/virtcontainers/qemu_s390x.go
+++ b/virtcontainers/qemu_s390x.go
@@ -100,9 +100,7 @@ func (q *qemuS390x) appendConsole(devices []govmmQemu.Device, path string) []gov
 
 	devices = append(devices, serial)
 
-	var console govmmQemu.CharDevice
-
-	console = govmmQemu.CharDevice{
+	console := govmmQemu.CharDevice{
 		Driver:   govmmQemu.Console,
 		Backend:  govmmQemu.Socket,
 		DeviceID: "console0",