From 27685c91e535a8cf538214b8530149f79a730087 Mon Sep 17 00:00:00 2001 From: Alex Lyn Date: Thu, 6 Jun 2024 16:58:39 +0800 Subject: [PATCH] kata-types: fix bug in kata-types several test cases (1) As mis-use of cap.set causing previous Caps lost which causing assert! failed, just replacing cap.set with cap.add. (2) It will return error if there's no such name setting when do update_config_by_annotation { ... if config.runtime.name.is_empty() { return Err(io::Error::new( io::ErrorKind::InvalidData, "Runtime name is missing in the configuration", )); } ... } Fixes #9783 Signed-off-by: Alex Lyn --- src/libs/kata-types/src/capabilities.rs | 2 +- src/libs/kata-types/tests/texture/configuration-anno-0.toml | 1 + src/libs/kata-types/tests/texture/configuration-anno-1.toml | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libs/kata-types/src/capabilities.rs b/src/libs/kata-types/src/capabilities.rs index 485e5bccdc..cf3d847b5e 100644 --- a/src/libs/kata-types/src/capabilities.rs +++ b/src/libs/kata-types/src/capabilities.rs @@ -127,7 +127,7 @@ mod tests { assert!(cap.is_fs_sharing_supported()); // test set hybrid-vsock support - cap.set(CapabilityBits::HybridVsockSupport); + cap.add(CapabilityBits::HybridVsockSupport); assert!(cap.is_hybrid_vsock_supported()); // test append capabilities cap.add(CapabilityBits::GuestMemoryProbe); diff --git a/src/libs/kata-types/tests/texture/configuration-anno-0.toml b/src/libs/kata-types/tests/texture/configuration-anno-0.toml index 807de57b69..7e997e79af 100644 --- a/src/libs/kata-types/tests/texture/configuration-anno-0.toml +++ b/src/libs/kata-types/tests/texture/configuration-anno-0.toml @@ -84,6 +84,7 @@ sandbox_bind_mounts=["/proc/self"] vfio_mode="vfio" experimental=["a", "b"] enable_pprof = true +name="virt-container" hypervisor_name = "qemu" agent_name = "agent0" diff --git a/src/libs/kata-types/tests/texture/configuration-anno-1.toml b/src/libs/kata-types/tests/texture/configuration-anno-1.toml index 59c05c9b59..1ca9f9ae73 100644 --- a/src/libs/kata-types/tests/texture/configuration-anno-1.toml +++ b/src/libs/kata-types/tests/texture/configuration-anno-1.toml @@ -83,6 +83,7 @@ sandbox_bind_mounts=["/proc/self"] vfio_mode="vfio" experimental=["a", "b"] enable_pprof = true +name="virt-container" hypervisor_name = "qemu" agent_name = "agent0"