From 4af4a8ad2b533e0480dd4c13772a32a1bc4ce4e6 Mon Sep 17 00:00:00 2001
From: "James O. D. Hunt" <james.o.hunt@intel.com>
Date: Mon, 11 Mar 2024 13:28:41 +0000
Subject: [PATCH 1/2] tests: static checker: Create setup function

Move some of the common code into a setup function.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
---
 tests/static-checks.sh | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/static-checks.sh b/tests/static-checks.sh
index 3be5e4c336..a38405b465 100755
--- a/tests/static-checks.sh
+++ b/tests/static-checks.sh
@@ -330,8 +330,6 @@ static_check_go_arch_specific()
 # Install yamllint in the different Linux distributions
 install_yamllint()
 {
-	source /etc/os-release || source /usr/lib/os-release
-
 	package="yamllint"
 
 	case "$ID" in
@@ -1399,9 +1397,16 @@ run_or_list_check_function()
 	eval "$func"
 }
 
+setup()
+{
+	source /etc/os-release || source /usr/lib/os-release
+
+	trap remove_tmp_files EXIT
+}
+
 main()
 {
-	trap remove_tmp_files EXIT
+	setup
 
 	local long_option_names="${!long_options[@]}"
 

From 577abd014b33bbcf833d4bf07c65111a2d62d77f Mon Sep 17 00:00:00 2001
From: "James O. D. Hunt" <james.o.hunt@intel.com>
Date: Mon, 11 Mar 2024 13:30:16 +0000
Subject: [PATCH 2/2] tests: static checker: Add announce message

Added an announcement message to the `static-checks.sh` script. It runs
platform / architecture specific code so it would be useful to display
details of the platform the checker is running on to help with
debugging.

Fixes: #9258.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
---
 tests/static-checks.sh | 52 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/static-checks.sh b/tests/static-checks.sh
index a38405b465..3f4b9c2b29 100755
--- a/tests/static-checks.sh
+++ b/tests/static-checks.sh
@@ -1404,6 +1404,56 @@ setup()
 	trap remove_tmp_files EXIT
 }
 
+# Display a message showing some system details.
+announce()
+{
+	local arch
+	arch=$(uname -m)
+
+	local file='/proc/cpuinfo'
+
+	local detail
+	detail=$(grep -m 1 -E '\<vendor_id\>|\<cpu\> *	*:' "$file" \
+		2>/dev/null |\
+		cut -d: -f2- |\
+		tr -d ' ' || true)
+
+	local arch="$arch"
+
+	[ -n "$detail" ] && arch+=" ('$detail')"
+
+	local kernel
+	kernel=$(uname -r)
+
+	local distro_name
+	local distro_version
+
+	distro_name="${NAME:-}"
+	distro_version="${VERSION:-}"
+
+	local -a lines
+
+	local IFS=$'\n'
+
+    lines=( $(cat <<-EOF
+	Running static checks:
+	  script: $script_name
+	  architecture: $arch
+	  kernel: $kernel
+	  distro:
+	    name: $distro_name
+	    version: $distro_version
+	EOF
+	))
+
+	local line
+
+	for line in "${lines[@]}"
+	do
+		info "$line"
+	done
+}
+
 main()
 {
 	setup
@@ -1482,6 +1532,8 @@ main()
 
 	repo_path=$GOPATH/src/$repo
 
+	announce
+
 	local all_check_funcs=$(typeset -F|awk '{print $3}'|grep "${check_func_regex}"|sort)
 
 	# Run user-specified check and quit