mirror of
https://github.com/kata-containers/kata-containers.git
synced 2025-04-30 12:44:39 +00:00
sandbox: Disconnect from agent after VM shutdown
When a one-shot pod dies in CRI-O, the shimv2 process isn't killed until the pod is actually deleted, even though the VM is shut down. In this case, the shim appears to busyloop when attempting to talk to the (now dead) agent via VSOCK. To address this, we disconnect from the agent after the VM is shut down. This is especially catastrophic for one-shot pods that may persist for hours or days, but it also applies to any shimv2 pod where Kata is configured to use VSOCK for communication. See github.com/kata-containers/runtime#2719 for details. Fixes #2719 Signed-off-by: Evan Foster <efoster@adobe.com>
This commit is contained in:
parent
bba2773d7d
commit
282bff9f94
@ -1623,6 +1623,11 @@ func (s *Sandbox) Stop(force bool) error {
|
||||
return err
|
||||
}
|
||||
|
||||
// Stop communicating with the agent.
|
||||
if err := s.agent.disconnect(); err != nil && !force {
|
||||
return err
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user