mirror of
https://github.com/kata-containers/kata-containers.git
synced 2025-04-30 20:54:26 +00:00
kernel: update to 5.4.71
vsock fix was backported to 5.4 stable, so we can drop this patch. Fixes: #973 Signed-off-by: Eric Ernst <eric.g.ernst@gmail.com>
This commit is contained in:
parent
238e4562e0
commit
2d1f2c7b95
@ -1,49 +0,0 @@
|
|||||||
From ac1956caf20f8ac0589f69b2d5fcc81e6ba7c71a Mon Sep 17 00:00:00 2001
|
|
||||||
From: Sebastien Boeuf <sebastien.boeuf@intel.com>
|
|
||||||
Date: Thu, 13 Feb 2020 08:50:38 +0100
|
|
||||||
Subject: [PATCH] net: virtio_vsock: Fix race condition between bind and listen
|
|
||||||
|
|
||||||
Whenever the vsock backend on the host sends a packet through the RX
|
|
||||||
queue, it expects an answer on the TX queue. Unfortunately, there is one
|
|
||||||
case where the host side will hang waiting for the answer and will
|
|
||||||
effectively never recover.
|
|
||||||
|
|
||||||
This issue happens when the guest side starts binding to the socket,
|
|
||||||
which insert a new bound socket into the list of already bound sockets.
|
|
||||||
At this time, we expect the guest to also start listening, which will
|
|
||||||
trigger the sk_state to move from TCP_CLOSE to TCP_LISTEN. The problem
|
|
||||||
occurs if the host side queued a RX packet and triggered an interrupt
|
|
||||||
right between the end of the binding process and the beginning of the
|
|
||||||
listening process. In this specific case, the function processing the
|
|
||||||
packet virtio_transport_recv_pkt() will find a bound socket, which means
|
|
||||||
it will hit the switch statement checking for the sk_state, but the
|
|
||||||
state won't be changed into TCP_LISTEN yet, which leads the code to pick
|
|
||||||
the default statement. This default statement will only free the buffer,
|
|
||||||
while it should also respond to the host side, by sending a packet on
|
|
||||||
its TX queue.
|
|
||||||
|
|
||||||
In order to simply fix this unfortunate chain of events, it is important
|
|
||||||
that in case the default statement is entered, and because at this stage
|
|
||||||
we know the host side is waiting for an answer, we must send back a
|
|
||||||
packet containing the operation VIRTIO_VSOCK_OP_RST.
|
|
||||||
|
|
||||||
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
|
|
||||||
---
|
|
||||||
net/vmw_vsock/virtio_transport_common.c | 1 +
|
|
||||||
1 file changed, 1 insertion(+)
|
|
||||||
|
|
||||||
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
|
|
||||||
index fb2060dffb0a..696e9a03ad0f 100644
|
|
||||||
--- a/net/vmw_vsock/virtio_transport_common.c
|
|
||||||
+++ b/net/vmw_vsock/virtio_transport_common.c
|
|
||||||
@@ -1127,6 +1127,7 @@ void virtio_transport_recv_pkt(struct virtio_vsock_pkt *pkt)
|
|
||||||
virtio_transport_free_pkt(pkt);
|
|
||||||
break;
|
|
||||||
default:
|
|
||||||
+ (void)virtio_transport_reset_no_sock(pkt);
|
|
||||||
virtio_transport_free_pkt(pkt);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
--
|
|
||||||
2.20.1
|
|
||||||
|
|
@ -155,7 +155,7 @@ assets:
|
|||||||
url: "https://cdn.kernel.org/pub/linux/kernel/v4.x/"
|
url: "https://cdn.kernel.org/pub/linux/kernel/v4.x/"
|
||||||
uscan-url: >-
|
uscan-url: >-
|
||||||
https://mirrors.edge.kernel.org/pub/linux/kernel/v5.x/linux-(5\.4\..+)\.tar\.gz
|
https://mirrors.edge.kernel.org/pub/linux/kernel/v5.x/linux-(5\.4\..+)\.tar\.gz
|
||||||
version: "v5.4.60"
|
version: "v5.4.71"
|
||||||
|
|
||||||
kernel-experimental:
|
kernel-experimental:
|
||||||
description: "Linux kernel with virtio-fs support"
|
description: "Linux kernel with virtio-fs support"
|
||||||
|
Loading…
Reference in New Issue
Block a user