ci: gha: Remove ok-to-test label on every push

This removes the ok-to-test label on every push, except if the PR author
has write access to the repo (ie. permission to modify labels).

This protects against attackers who would initially open a genuine PR,
then push malicious code after the initial review.

Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
This commit is contained in:
Aurélien Bombo 2025-06-09 12:24:31 -05:00
parent 17b2daf0a7
commit 2ee3470627

View File

@ -0,0 +1,30 @@
name: Validate ok-to-test label
on:
pull_request_target:
types: [synchronize]
jobs:
remove-label-if-needed:
runs-on: ubuntu-22.04
permissions:
# SAFETY: Only enough to modify labels.
issues: write
steps:
- name: Remove ok-to-test label on push
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ github.event.pull_request.number }}
AUTHOR: ${{ github.event.pull_request.user.login }}
OWNER: ${{ github.repository.owner.login }}
REPO: ${{ github.event.repository.name }}
run: |
permission="$(gh api "repos/${OWNER}/${REPO}/collaborators/${AUTHOR}/permission" --jq '.permission')"
echo "User ${AUTHOR} has permission '${permission}'"
if [[ "${permission}" != "write" && "${permission}" != "admin" ]]; then
echo "Removing 'ok-to-test' label"
gh pr edit "${PR_NUMBER}" --repo "${OWNER}/${REPO}" --remove-label "ok-to-test"
else
echo "User has label permission - skipping removal"
fi