From a49b6f863431797add2332b5ec52fe0b7ae2a56d Mon Sep 17 00:00:00 2001 From: Shunsuke Kimura Date: Mon, 31 Mar 2025 08:57:32 +0900 Subject: [PATCH 1/2] kata-deploy: Moves the function to the top Move functions that may be used in validation to the top. Fixes: #11097 Signed-off-by: Shunsuke Kimura --- .../kata-deploy/scripts/kata-deploy.sh | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/tools/packaging/kata-deploy/scripts/kata-deploy.sh b/tools/packaging/kata-deploy/scripts/kata-deploy.sh index 244fbf4c2..7352f6b6d 100755 --- a/tools/packaging/kata-deploy/scripts/kata-deploy.sh +++ b/tools/packaging/kata-deploy/scripts/kata-deploy.sh @@ -16,6 +16,23 @@ containerd_conf_file_backup="${containerd_conf_file}.bak" containerd_conf_tmpl_file="" use_containerd_drop_in_conf_file="false" +# If we fail for any reason a message will be displayed +die() { + msg="$*" + echo "ERROR: $msg" >&2 + exit 1 +} + +warn() { + msg="$*" + echo "WARN: $msg" >&2 +} + +info() { + msg="$*" + echo "INFO: $msg" >&2 +} + DEBUG="${DEBUG:-"false"}" SHIMS="${SHIMS:-"clh cloud-hypervisor dragonball fc qemu qemu-coco-dev qemu-runtime-rs qemu-se-runtime-rs qemu-sev qemu-snp qemu-tdx stratovirt qemu-nvidia-gpu qemu-nvidia-gpu-snp qemu-nvidia-gpu-tdx"}" @@ -67,23 +84,6 @@ host_install_dir="/host${dest_dir}" HELM_POST_DELETE_HOOK="${HELM_POST_DELETE_HOOK:-"false"}" -# If we fail for any reason a message will be displayed -die() { - msg="$*" - echo "ERROR: $msg" >&2 - exit 1 -} - -warn() { - msg="$*" - echo "WARN: $msg" >&2 -} - -info() { - msg="$*" - echo "INFO: $msg" >&2 -} - function host_systemctl() { nsenter --target 1 --mount systemctl "${@}" } From a05f5f1827e35fb51f62f0cc4e7cc9c6b7ae87ee Mon Sep 17 00:00:00 2001 From: Shunsuke Kimura Date: Fri, 28 Mar 2025 17:14:14 +0900 Subject: [PATCH 2/2] kata-deploy: add INSTALLATION_PREFIX validation INSTALLATION_PREFIX must begin with a "/" because it is being concatenated with /host. If there is no /, displays a message and makes an error. Fixes: #11096 Signed-off-by: Shunsuke Kimura --- tools/packaging/kata-deploy/scripts/kata-deploy.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/packaging/kata-deploy/scripts/kata-deploy.sh b/tools/packaging/kata-deploy/scripts/kata-deploy.sh index 7352f6b6d..75d9709a7 100755 --- a/tools/packaging/kata-deploy/scripts/kata-deploy.sh +++ b/tools/packaging/kata-deploy/scripts/kata-deploy.sh @@ -66,6 +66,9 @@ INSTALLATION_PREFIX="${INSTALLATION_PREFIX:-}" default_dest_dir="/opt/kata" dest_dir="${default_dest_dir}" if [ -n "${INSTALLATION_PREFIX}" ]; then + if [[ "${INSTALLATION_PREFIX:0:1}" != "/" ]]; then + die 'INSTALLATION_PREFIX must begin with a "/"(ex. /hoge/fuga)' + fi # There's no `/` in between ${INSTALLATION_PREFIX} and ${default_dest_dir} # as, otherwise, we'd have it doubled there, as: `/foo/bar//opt/kata` dest_dir="${INSTALLATION_PREFIX}${default_dest_dir}"