github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-08-13 21:56:32 +00:00
Code Issues Projects Releases Wiki Activity

tracing: Unbreak tracing test

Browse Source 
Force Jaeger to log when it reports traces to ensure the tracing test
[1] works as expected.

Fixes: #2264.

[1] - https://github.com/kata-containers/tests/blob/master/tracing/tracing-test.sh

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This commit is contained in:
James O. D. Hunt 2019-11-25 16:48:41 +00:00
parent 562d9fd5c2
commit 330cc72ef3
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/katautils/tracing.go
View File

@ -44,6 +44,14 @@ func CreateTracer(name string) (opentracing.Tracer, error) {
Type: "const", Type: "const",
Param: 1, Param: 1,
}, },
// Ensure that Jaeger logs each span.
// This is essential as it is used by:
//
// https: //github.com/kata-containers/tests/blob/master/tracing/tracing-test.sh
Reporter: &config.ReporterConfig{
LogSpans: tracing,
},
} }
logger := traceLogger{} logger := traceLogger{}
@ -92,6 +100,8 @@ func Trace(parent context.Context, name string) (opentracing.Span, context.Conte
// are still created - but the tracer used is a NOP. Therefore, only // are still created - but the tracer used is a NOP. Therefore, only
// display the message when tracing is really enabled. // display the message when tracing is really enabled.
if tracing { if tracing {
// This log message is *essential*: it is used by:
// https: //github.com/kata-containers/tests/blob/master/tracing/tracing-test.sh
kataUtilsLogger.Debugf("created span %v", span) kataUtilsLogger.Debugf("created span %v", span)
} }