github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-29 00:37:24 +00:00
Code Issues Projects Releases Wiki Activity

virtcontainers: check minimum supported version of firecracker

Browse Source 
Check minimum supported version of firecracker to make sure it's compatible
with kata containers

Signed-off-by: Julio Montes <julio.montes@intel.com>
This commit is contained in:
Julio Montes 2019-09-20 13:43:24 +00:00
parent 8680db6071
commit 3d0949d60d
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
virtcontainers/fc.go
View File

@ -30,7 +30,9 @@ import (
"github.com/pkg/errors" "github.com/pkg/errors"
"github.com/sirupsen/logrus" "github.com/sirupsen/logrus"
"github.com/blang/semver"
"github.com/kata-containers/runtime/virtcontainers/device/config" "github.com/kata-containers/runtime/virtcontainers/device/config"
fcmodels "github.com/kata-containers/runtime/virtcontainers/pkg/firecracker/client/models"
"github.com/kata-containers/runtime/virtcontainers/store" "github.com/kata-containers/runtime/virtcontainers/store"
"github.com/kata-containers/runtime/virtcontainers/types" "github.com/kata-containers/runtime/virtcontainers/types"
"github.com/kata-containers/runtime/virtcontainers/utils" "github.com/kata-containers/runtime/virtcontainers/utils"
@ -66,6 +68,9 @@ const (
defaultGuestVSockCID = int64(0x3) defaultGuestVSockCID = int64(0x3)
) )
// Specify the minimum version of firecracker supported
var fcMinSupportedVersion = semver.MustParse("0.18.0")
var fcKernelParams = append(commonVirtioblkKernelRootParams, []Param{ var fcKernelParams = append(commonVirtioblkKernelRootParams, []Param{
// The boot source is the first partition of the first block device added // The boot source is the first partition of the first block device added
{"pci", "off"}, {"pci", "off"},
@ -296,6 +301,23 @@ func (fc *firecracker) vmRunning() bool {
} }
} }
func (fc *firecracker) checkVersion(vmmInfo *fcmodels.InstanceInfo) error {
if vmmInfo == nil || vmmInfo.VmmVersion == nil {
return fmt.Errorf("Unknown firecracker version")
}
v, err := semver.Make(*vmmInfo.VmmVersion)
if err != nil {
return fmt.Errorf("Malformed firecracker version: %v", err)
}
if v.LT(fcMinSupportedVersion) {
return fmt.Errorf("version %v is not supported. Minimum supported version of firecracker is %v", v.String(), fcMinSupportedVersion.String())
}
return nil
}
// waitVMM will wait for timeout seconds for the VMM to be up and running. // waitVMM will wait for timeout seconds for the VMM to be up and running.
// This does not mean that the VM is up and running. It only indicates that the VMM is up and // This does not mean that the VM is up and running. It only indicates that the VMM is up and
// running and able to handle commands to setup and launch a VM // running and able to handle commands to setup and launch a VM
@ -309,8 +331,11 @@ func (fc *firecracker) waitVMM(timeout int) error {
timeStart := time.Now() timeStart := time.Now()
for { for {
_, err := fc.client().Operations.DescribeInstance(nil) vmmInfo, err := fc.client().Operations.DescribeInstance(nil)
if err == nil { if err == nil {
if err := fc.checkVersion(vmmInfo.Payload); err != nil {
return err
}
return nil return nil
} }