github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-05-01 05:04:26 +00:00
Code Issues Projects Releases Wiki Activity

runtime: fix wrong issue links

Browse Source 
Fix issue links in source codes.

Fixes: #391

Signed-off-by: bin liu <bin@hyper.sh>
This commit is contained in:
bin liu 2020-07-07 16:35:43 +08:00
parent 57dfda9b3d
commit 41c04648ad
13 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/cli/kata-check_amd64.go
View File

@ -53,7 +53,7 @@ const acrnDevice = "/dev/acrn_vhm"
// Due to this several macros are not defined in Linux headers. // Due to this several macros are not defined in Linux headers.
// Until the support is available, directly use the value instead // Until the support is available, directly use the value instead
// of macros. // of macros.
//https://github.com/kata-containers/kata-containers/src/runtime/issues/1784 //https://github.com/kata-containers/runtime/issues/1784
const ioctl_ACRN_CREATE_VM = 0x43000010 //nolint const ioctl_ACRN_CREATE_VM = 0x43000010 //nolint
const ioctl_ACRN_DESTROY_VM = 0x43000011 //nolint const ioctl_ACRN_DESTROY_VM = 0x43000011 //nolint

2
src/runtime/cli/main.go
View File

@ -282,7 +282,7 @@ func beforeSubcommands(c *cli.Context) error {
rootless.SetRootless(*r) rootless.SetRootless(*r)
} }
// Support --systed-cgroup // Support --systed-cgroup
// Issue: https://github.com/kata-containers/kata-containers/src/runtime/issues/2428 // Issue: https://github.com/kata-containers/runtime/issues/2428
ignoreConfigLogs := false ignoreConfigLogs := false
var traceRootSpan string var traceRootSpan string

2
src/runtime/virtcontainers/acrn.go
View File

@ -105,7 +105,7 @@ const acrnDevice = "/dev/acrn_vhm"
// Due to this several macros are not defined in Linux headers. // Due to this several macros are not defined in Linux headers.
// Until the support is available, directly use the value instead // Until the support is available, directly use the value instead
// of macros. // of macros.
//https://github.com/kata-containers/kata-containers/src/runtime/issues/1784 //https://github.com/kata-containers/runtime/issues/1784
const ioctl_ACRN_GET_PLATFORM_INFO = 0x43000003 //nolint const ioctl_ACRN_GET_PLATFORM_INFO = 0x43000003 //nolint
const ( const (

8
src/runtime/virtcontainers/container.go
View File

@ -823,7 +823,7 @@ func (c *Container) create() (err error) {
normalAttachedDevs []ContainerDevice //for q35: normally attached devices normalAttachedDevs []ContainerDevice //for q35: normally attached devices
delayAttachedDevs []ContainerDevice //for q35: delay attached devices, for example, large bar space device delayAttachedDevs []ContainerDevice //for q35: delay attached devices, for example, large bar space device
) )
// Fix: https://github.com/kata-containers/kata-containers/src/runtime/issues/2460 // Fix: https://github.com/kata-containers/runtime/issues/2460
if machineType == QemuQ35 { if machineType == QemuQ35 {
// add Large Bar space device to delayAttachedDevs // add Large Bar space device to delayAttachedDevs
for _, device := range c.devices { for _, device := range c.devices {
@ -1326,7 +1326,7 @@ func (c *Container) attachDevices(devices []ContainerDevice) error {
// since devices with large bar space require delayed attachment, // since devices with large bar space require delayed attachment,
// the devices need to be split into two lists, normalAttachedDevs and delayAttachedDevs. // the devices need to be split into two lists, normalAttachedDevs and delayAttachedDevs.
// so c.device is not used here. See issue https://github.com/kata-containers/kata-containers/src/runtime/issues/2460. // so c.device is not used here. See issue https://github.com/kata-containers/runtime/issues/2460.
for _, dev := range devices { for _, dev := range devices {
if err := c.sandbox.devManager.AttachDevice(dev.ID, c.sandbox); err != nil { if err := c.sandbox.devManager.AttachDevice(dev.ID, c.sandbox); err != nil {
return err return err
@ -1364,7 +1364,7 @@ func (c *Container) cgroupsCreate() (err error) {
return errorMissingOCISpec return errorMissingOCISpec
} }
// https://github.com/kata-containers/kata-containers/src/runtime/issues/168 // https://github.com/kata-containers/runtime/issues/168
resources := specs.LinuxResources{ resources := specs.LinuxResources{
CPU: nil, CPU: nil,
} }
@ -1450,7 +1450,7 @@ func (c *Container) cgroupsUpdate(resources specs.LinuxResources) error {
return fmt.Errorf("Could not load cgroup %v: %v", c.state.CgroupPath, err) return fmt.Errorf("Could not load cgroup %v: %v", c.state.CgroupPath, err)
} }
// Issue: https://github.com/kata-containers/kata-containers/src/runtime/issues/168 // Issue: https://github.com/kata-containers/runtime/issues/168
r := specs.LinuxResources{ r := specs.LinuxResources{
CPU: validCPUResources(resources.CPU), CPU: validCPUResources(resources.CPU),
} }

2
src/runtime/virtcontainers/device/drivers/block.go
View File

@ -97,7 +97,7 @@ func (device *BlockDevice) Attach(devReceiver api.DeviceReceiver) (err error) {
//Longer term block based VM rootfs should be added //Longer term block based VM rootfs should be added
//as a regular block device which eliminates the //as a regular block device which eliminates the
//offset. //offset.
//https://github.com/kata-containers/kata-containers/src/runtime/issues/1061 //https://github.com/kata-containers/runtime/issues/1061
globalIdx = index + 1 globalIdx = index + 1
} }

6
src/runtime/virtcontainers/fc.go
View File

@ -203,7 +203,7 @@ func (fc *firecracker) createSandbox(ctx context.Context, id string, networkNS N
defer span.Finish() defer span.Finish()
//TODO: check validity of the hypervisor config provided //TODO: check validity of the hypervisor config provided
//https://github.com/kata-containers/kata-containers/src/runtime/issues/1065 //https://github.com/kata-containers/runtime/issues/1065
fc.id = fc.truncateID(id) fc.id = fc.truncateID(id)
fc.state.set(notReady) fc.state.set(notReady)
fc.config = *hypervisorConfig fc.config = *hypervisorConfig
@ -233,7 +233,7 @@ func (fc *firecracker) createSandbox(ctx context.Context, id string, networkNS N
fc.netNSPath = networkNS.NetNsPath fc.netNSPath = networkNS.NetNsPath
// Till we create lower privileged kata user run as root // Till we create lower privileged kata user run as root
// https://github.com/kata-containers/kata-containers/src/runtime/issues/1869 // https://github.com/kata-containers/runtime/issues/1869
fc.uid = "0" fc.uid = "0"
fc.gid = "0" fc.gid = "0"
@ -381,7 +381,7 @@ func (fc *firecracker) fcInit(timeout int) error {
"--id", fc.id, "--id", fc.id,
"--node", "0", //FIXME: Comprehend NUMA topology or explicit ignore "--node", "0", //FIXME: Comprehend NUMA topology or explicit ignore
"--exec-file", fc.config.HypervisorPath, "--exec-file", fc.config.HypervisorPath,
"--uid", "0", //https://github.com/kata-containers/kata-containers/src/runtime/issues/1869 "--uid", "0", //https://github.com/kata-containers/runtime/issues/1869
"--gid", "0", "--gid", "0",
"--chroot-base-dir", fc.chrootBaseDir, "--chroot-base-dir", fc.chrootBaseDir,
} }

4
src/runtime/virtcontainers/kata_agent.go
View File

@ -1082,8 +1082,8 @@ func (k *kataAgent) constraintGRPCSpec(grpcSpec *grpc.Spec, passSeccomp bool) {
} }
// By now only CPU constraints are supported // By now only CPU constraints are supported
// Issue: https://github.com/kata-containers/kata-containers/src/runtime/issues/158 // Issue: https://github.com/kata-containers/runtime/issues/158
// Issue: https://github.com/kata-containers/kata-containers/src/runtime/issues/204 // Issue: https://github.com/kata-containers/runtime/issues/204
grpcSpec.Linux.Resources.Devices = nil grpcSpec.Linux.Resources.Devices = nil
grpcSpec.Linux.Resources.Pids = nil grpcSpec.Linux.Resources.Pids = nil
grpcSpec.Linux.Resources.BlockIO = nil grpcSpec.Linux.Resources.BlockIO = nil

2
src/runtime/virtcontainers/pkg/rootless/rootless.go
View File

@ -74,7 +74,7 @@ func isRootlessFunc() bool {
SetRootless(true) SetRootless(true)
// --rootless and --systemd-cgroup options must honoured // --rootless and --systemd-cgroup options must honoured
// but with the current implementation this is not possible // but with the current implementation this is not possible
// https://github.com/kata-containers/kata-containers/src/runtime/issues/2412 // https://github.com/kata-containers/runtime/issues/2412
if os.Geteuid() != 0 { if os.Geteuid() != 0 {
return true return true
} }

4
src/runtime/virtcontainers/proxy.go
View File

@ -191,7 +191,7 @@ func (p *proxyBuiltin) watchConsole(proto, console string, logger *logrus.Entry)
return err return err
} }
// TODO: please see // TODO: please see
// https://github.com/kata-containers/kata-containers/src/runtime/issues/1940. // https://github.com/kata-containers/runtime/issues/1940.
case consoleProtoPty: case consoleProtoPty:
fallthrough fallthrough
default: default:
@ -247,7 +247,7 @@ func (p *proxyBuiltin) start(params proxyParams) (int, string, error) {
// For firecracker, it hasn't support the console watching and it's consoleURL // For firecracker, it hasn't support the console watching and it's consoleURL
// will be set empty. // will be set empty.
// TODO: add support for hybrid vsocks, see https://github.com/kata-containers/kata-containers/src/runtime/issues/2098 // TODO: add support for hybrid vsocks, see https://github.com/kata-containers/runtime/issues/2098
if params.debug && params.consoleURL != "" && !strings.HasPrefix(params.consoleURL, kataclient.HybridVSockScheme) { if params.debug && params.consoleURL != "" && !strings.HasPrefix(params.consoleURL, kataclient.HybridVSockScheme) {
err := p.watchConsole(buildinProxyConsoleProto, params.consoleURL, params.logger) err := p.watchConsole(buildinProxyConsoleProto, params.consoleURL, params.logger)
if err != nil { if err != nil {

2
src/runtime/virtcontainers/qemu.go
View File

@ -2066,7 +2066,7 @@ func calcHotplugMemMiBSize(mem uint32, memorySectionSizeMB uint32) (uint32, erro
return mem, nil return mem, nil
} }
// TODO: hot add memory aligned to memory section should be more properly. See https://github.com/kata-containers/kata-containers/src/runtime/pull/624#issuecomment-419656853 // TODO: hot add memory aligned to memory section should be more properly. See https://github.com/kata-containers/runtime/pull/624#issuecomment-419656853
return uint32(math.Ceil(float64(mem)/float64(memorySectionSizeMB))) * memorySectionSizeMB, nil return uint32(math.Ceil(float64(mem)/float64(memorySectionSizeMB))) * memorySectionSizeMB, nil
} }

2
src/runtime/virtcontainers/qemu_amd64.go
View File

@ -160,7 +160,7 @@ func (q *qemuAmd64) cpuModel() string {
cpuModel := defaultCPUModel cpuModel := defaultCPUModel
// VMX is not migratable yet. // VMX is not migratable yet.
// issue: https://github.com/kata-containers/kata-containers/src/runtime/issues/1750 // issue: https://github.com/kata-containers/runtime/issues/1750
if q.vmFactory { if q.vmFactory {
virtLog.WithField("subsystem", "qemuAmd64").Warn("VMX is not migratable yet: turning it off") virtLog.WithField("subsystem", "qemuAmd64").Warn("VMX is not migratable yet: turning it off")
cpuModel += ",vmx=off" cpuModel += ",vmx=off"

2
src/runtime/virtcontainers/qemu_s390x.go
View File

@ -152,7 +152,7 @@ func (q *qemuS390x) appendCCWBlockDevice(devices []govmmQemu.Device, drive confi
} }
// appendVhostUserDevice throws an error if vhost devices are tried to be used. // appendVhostUserDevice throws an error if vhost devices are tried to be used.
// See issue https://github.com/kata-containers/kata-containers/src/runtime/issues/659 // See issue https://github.com/kata-containers/runtime/issues/659
func (q *qemuS390x) appendVhostUserDevice(devices []govmmQemu.Device, attr config.VhostUserDeviceAttrs) ([]govmmQemu.Device, error) { func (q *qemuS390x) appendVhostUserDevice(devices []govmmQemu.Device, attr config.VhostUserDeviceAttrs) ([]govmmQemu.Device, error) {
return nil, fmt.Errorf("No vhost-user devices supported on s390x") return nil, fmt.Errorf("No vhost-user devices supported on s390x")
} }

2
src/runtime/virtcontainers/utils/utils_linux_ppc64le.go
View File

@ -10,7 +10,7 @@ package utils
// _IOC_WRITE is 1 for arch generic and 4 for powerpc // _IOC_WRITE is 1 for arch generic and 4 for powerpc
// Code reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/uapi/asm/ioctl.h // Code reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/uapi/asm/ioctl.h
// Explanation: https://github.com/kata-containers/kata-containers/src/runtime/pull/1989#issuecomment-525993135 // Explanation: https://github.com/kata-containers/runtime/pull/1989#issuecomment-525993135
const ioctlVhostVsockSetGuestCid = 0x8008AF60 const ioctlVhostVsockSetGuestCid = 0x8008AF60
func getIoctlVhostVsockGuestCid() uintptr { func getIoctlVhostVsockGuestCid() uintptr {