Merge pull request #1943 from bergwolf/cleanup2

cleanup TODOs in runtime
This commit is contained in:
Peng Tao
2021-06-01 14:16:46 +08:00
committed by GitHub
3 changed files with 0 additions and 3 deletions

View File

@@ -34,7 +34,6 @@ type SandboxState struct {
// CgroupPath is the cgroup hierarchy where sandbox's processes
// including the hypervisor are placed.
// FIXME: sandbox can reuse "SandboxContainer"'s CgroupPath so we can remove this field.
CgroupPath string
// CgroupPath is the cgroup hierarchy where sandbox's processes

View File

@@ -2196,7 +2196,6 @@ func calcHotplugMemMiBSize(mem uint32, memorySectionSizeMB uint32) (uint32, erro
return mem, nil
}
// TODO: hot add memory aligned to memory section should be more properly. See https://github.com/kata-containers/runtime/pull/624#issuecomment-419656853
return uint32(math.Ceil(float64(mem)/float64(memorySectionSizeMB))) * memorySectionSizeMB, nil
}

View File

@@ -1270,7 +1270,6 @@ func (s *Sandbox) DeleteContainer(ctx context.Context, containerID string) (VCCo
}
// StatusContainer gets the status of a container
// TODO: update container status properly, see kata-containers/runtime#253
func (s *Sandbox) StatusContainer(containerID string) (ContainerStatus, error) {
if containerID == "" {
return ContainerStatus{}, vcTypes.ErrNeedContainerID