github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-28 08:17:37 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1943 from bergwolf/cleanup2

Browse Source 
cleanup TODOs in runtime
This commit is contained in:
Peng Tao 2021-06-01 14:16:46 +08:00 committed by GitHub
commit 41e04495f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/runtime/virtcontainers/persist/api/sandbox.go
View File

@ -34,7 +34,6 @@ type SandboxState struct {
// CgroupPath is the cgroup hierarchy where sandbox's processes // CgroupPath is the cgroup hierarchy where sandbox's processes
// including the hypervisor are placed. // including the hypervisor are placed.
// FIXME: sandbox can reuse "SandboxContainer"'s CgroupPath so we can remove this field.
CgroupPath string CgroupPath string
// CgroupPath is the cgroup hierarchy where sandbox's processes // CgroupPath is the cgroup hierarchy where sandbox's processes

1
src/runtime/virtcontainers/qemu.go
View File

@ -2196,7 +2196,6 @@ func calcHotplugMemMiBSize(mem uint32, memorySectionSizeMB uint32) (uint32, erro
return mem, nil return mem, nil
} }
// TODO: hot add memory aligned to memory section should be more properly. See https://github.com/kata-containers/runtime/pull/624#issuecomment-419656853
return uint32(math.Ceil(float64(mem)/float64(memorySectionSizeMB))) * memorySectionSizeMB, nil return uint32(math.Ceil(float64(mem)/float64(memorySectionSizeMB))) * memorySectionSizeMB, nil
} }

1
src/runtime/virtcontainers/sandbox.go
View File

@ -1270,7 +1270,6 @@ func (s *Sandbox) DeleteContainer(ctx context.Context, containerID string) (VCCo
} }
// StatusContainer gets the status of a container // StatusContainer gets the status of a container
// TODO: update container status properly, see kata-containers/runtime#253
func (s *Sandbox) StatusContainer(containerID string) (ContainerStatus, error) { func (s *Sandbox) StatusContainer(containerID string) (ContainerStatus, error) {
if containerID == "" { if containerID == "" {
return ContainerStatus{}, vcTypes.ErrNeedContainerID return ContainerStatus{}, vcTypes.ErrNeedContainerID