From 50bf4434dd33d55295e4fa1059bf448d0e1b942c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Thu, 17 Nov 2022 14:17:29 +0100 Subject: [PATCH] log-parser: Simplify check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` 14:13:15 parse.go:306:5: S1009: should omit nil check; len() for github.com/kata-containers/kata-containers/src/tools/log-parser.kvPairs is defined as zero (gosimple) 14:13:15 if pairs == nil || len(pairs) == 0 { 14:13:15 ^ ``` Signed-off-by: Fabiano Fidêncio (cherry picked from commit 2f5f575a43b5d7a5fbbd582d5c015e8ac92895cd) --- src/tools/log-parser/parse.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/log-parser/parse.go b/src/tools/log-parser/parse.go index 9529727e4..654cfd623 100644 --- a/src/tools/log-parser/parse.go +++ b/src/tools/log-parser/parse.go @@ -303,7 +303,7 @@ func createLogEntry(filename string, line uint64, pairs kvPairs) (LogEntry, erro return LogEntry{}, fmt.Errorf("need line number for file %v", filename) } - if pairs == nil || len(pairs) == 0 { + if len(pairs) == 0 { return LogEntry{}, fmt.Errorf("need key/value pairs for line %v:%d", filename, line) }