mirror of
https://github.com/kata-containers/kata-containers.git
synced 2025-07-04 02:56:18 +00:00
versions: Update golang to 1.10.4
Move to golang version 1.10.4 -- the oldest stable golang release at the
time of writing -- since golang 1.10+ is needed to make namespace
handling safe.
Re-ordered a couple of structs (moved `sync.WaitGroup` fields) to keep
the `maligned` linter happy. Previously:
``
virtcontainers/pkg/mock/cc_proxy_mock.go:24:18⚠️ struct of size 160 could be 152 (maligned)
virtcontainers/monitor.go:15:14⚠️ struct of size 80 could be 72 (maligned)
```
See:
- https://github.com/golang/go/issues/20676
- 2595fe7fb6
Also bumped `languages.golang.meta.newest-version` to golang version
1.11, which is the newest stable release at the time of writing.
Fixes #148.
Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This commit is contained in:
parent
62992f5485
commit
526d55b4af
@ -186,9 +186,10 @@ languages:
|
||||
golang:
|
||||
description: "Google's 'go' language"
|
||||
notes: "'version' is the default minimum version used by this project."
|
||||
version: "1.9.7"
|
||||
issue: "https://github.com/golang/go/issues/20676"
|
||||
version: "1.10.4"
|
||||
meta:
|
||||
newest-version: "1.10"
|
||||
newest-version: "1.11"
|
||||
|
||||
specs:
|
||||
description: "Details of important specifications"
|
||||
|
@ -18,9 +18,9 @@ type monitor struct {
|
||||
sandbox *Sandbox
|
||||
checkInterval time.Duration
|
||||
watchers []chan error
|
||||
wg sync.WaitGroup
|
||||
running bool
|
||||
stopCh chan bool
|
||||
wg sync.WaitGroup
|
||||
}
|
||||
|
||||
func newMonitor(s *Sandbox) *monitor {
|
||||
|
@ -25,7 +25,6 @@ type CCProxyMock struct {
|
||||
sync.Mutex
|
||||
|
||||
t *testing.T
|
||||
wg sync.WaitGroup
|
||||
connectionPath string
|
||||
|
||||
// proxy socket
|
||||
@ -44,6 +43,8 @@ type CCProxyMock struct {
|
||||
ShimDisconnected chan bool
|
||||
StdinReceived chan bool
|
||||
|
||||
wg sync.WaitGroup
|
||||
|
||||
stopped bool
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user