github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-29 08:47:56 +00:00
Code Issues Projects Releases Wiki Activity

virtcontainers: cleanup the container config once failed

Browse Source 
When create container failed, it should delete the container
config from sandbox, otherwise, the following new creating container
would get a wrong resources caculating which would contain the previous
failed container resources such as memory and cpu.

Fixes: #1997

Signed-off-by: lifupan <lifupan@gmail.com>
This commit is contained in:
lifupan 2019-08-22 13:43:42 +08:00
parent 5b749a56d8
commit 52e68f5fce
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
virtcontainers/sandbox.go
View File

@ -1116,6 +1116,13 @@ func (s *Sandbox) CreateContainer(contConfig ContainerConfig) (VCContainer, erro
// Update sandbox config. // Update sandbox config.
s.config.Containers = append(s.config.Containers, contConfig) s.config.Containers = append(s.config.Containers, contConfig)
defer func() {
if err != nil && len(s.config.Containers) > 0 {
// delete container config
s.config.Containers = s.config.Containers[:len(s.config.Containers)-1]
}
}()
// Sandbox is reponsable to update VM resources needed by Containers // Sandbox is reponsable to update VM resources needed by Containers
err = s.updateResources() err = s.updateResources()
if err != nil { if err != nil {
@ -1128,7 +1135,7 @@ func (s *Sandbox) CreateContainer(contConfig ContainerConfig) (VCContainer, erro
} }
// Add the container to the containers list in the sandbox. // Add the container to the containers list in the sandbox.
if err := s.addContainer(c); err != nil { if err = s.addContainer(c); err != nil {
return nil, err return nil, err
} }
@ -1138,7 +1145,7 @@ func (s *Sandbox) CreateContainer(contConfig ContainerConfig) (VCContainer, erro
return nil, err return nil, err
} }
if err := s.updateCgroups(); err != nil { if err = s.updateCgroups(); err != nil {
return nil, err return nil, err
} }

6
virtcontainers/sandbox_test.go
View File

@ -909,6 +909,12 @@ func TestCreateContainer(t *testing.T) {
contConfig := newTestContainerConfigNoop(contID) contConfig := newTestContainerConfigNoop(contID)
_, err = s.CreateContainer(contConfig) _, err = s.CreateContainer(contConfig)
assert.Nil(t, err, "Failed to create container %+v in sandbox %+v: %v", contConfig, s, err) assert.Nil(t, err, "Failed to create container %+v in sandbox %+v: %v", contConfig, s, err)
assert.Equal(t, len(s.config.Containers), 1, "Container config list length from sandbox structure should be 1")
_, err = s.CreateContainer(contConfig)
assert.NotNil(t, err, "Should failed to create a duplicated container")
assert.Equal(t, len(s.config.Containers), 1, "Container config list length from sandbox structure should be 1")
} }
func TestDeleteContainer(t *testing.T) { func TestDeleteContainer(t *testing.T) {