github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-07-16 16:32:03 +00:00
Code Issues Projects Releases Wiki Activity

virtcontainers: Fix TestIsHostDevice test as non-root

Browse Source 
Don't Attempt to create file below `/dev` when running as non-`root`.

Move the logic into a new `TestIsHostDeviceCreateFile` test and skip
unless `root.`

Fixes #242.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This commit is contained in:
James O. D. Hunt 2018-04-23 14:29:13 +01:00
parent de32be7eed
commit 53d73e56e0
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
virtcontainers/mount_test.go
View File

@ -8,7 +8,6 @@ package virtcontainers
import ( import (
"bytes" "bytes"
"fmt" "fmt"
"github.com/stretchr/testify/assert"
"os" "os"
"os/exec" "os/exec"
"path/filepath" "path/filepath"
@ -16,6 +15,8 @@ import (
"strings" "strings"
"syscall" "syscall"
"testing" "testing"
"github.com/stretchr/testify/assert"
) )
func TestIsSystemMount(t *testing.T) { func TestIsSystemMount(t *testing.T) {
@ -60,8 +61,14 @@ func TestIsHostDevice(t *testing.T) {
t.Fatalf("Expected result for path %s : %v, got %v", test.mnt, test.expected, result) t.Fatalf("Expected result for path %s : %v, got %v", test.mnt, test.expected, result)
} }
} }
}
func TestIsHostDeviceCreateFile(t *testing.T) {
if os.Geteuid() != 0 {
t.Skip(testDisabledAsNonRoot)
}
// Create regular file in /dev // Create regular file in /dev
path := "/dev/foobar" path := "/dev/foobar"
f, err := os.Create(path) f, err := os.Create(path)
if err != nil { if err != nil {